Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jjamidei patch 1 #34

Open
wants to merge 13 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

JJAmidei
Copy link

@klieret @pibion
Changed setup.md page to have installation instructions for windows, mac, and linux.

pibion and others added 9 commits April 18, 2023 15:07
…and Linux as well as made general edits to setup.md.
Added "Windows/Mac/Linux Installation and Access" sections. Also changed link for "How to use Terminal on Mac" article to the "Unix Shell" software carpentry setup page (i.e. where the link was originally found).
Changed size of font for section titles
@welcome
Copy link

welcome bot commented Jun 21, 2023

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

Copy link
Member

@klieret klieret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR. Much appreciated!

setup.md Outdated

### Windows Installation and Access

If you are using Windows, you will need to install [the Windows Subsystem for Linux (WSL)](https://learn.microsoft.com/en-us/windows/wsl/install). WSL will have the ssh programs you need by default, so once you've installed WSL you are ready for this tutorial.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that newer Windows systems have SSH pre-installed in the Windows shell and you can use it in the same way. However, I'm not sure how it behaves regarding configs and the like. But figuring that out and perhaps adding a note could be something to figure out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Will look into and add whatever is relevant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to use this picture somewhere else? Because it doesn't seem to be referenced in the setup.md...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don´t think so. I'll double check with Amy, but I'm fairly certain that she made it for this tutorial specifically. I think she intended for it to be used on the Introduction page.

JJAmidei and others added 2 commits July 20, 2023 21:42
Added a brief section about OpenSSH for newer versions of windows as well as a link to Microsoft's page on getting started with OpenSSH.
setup.md Outdated

If you are using a version of Windows, you will need to install [the Windows Subsystem for Linux (WSL)](https://learn.microsoft.com/en-us/windows/wsl/install). WSL will have the ssh programs you need by default, so once you've installed WSL you are ready for this tutorial.

Note: If your version of Windows is either Windows 10 version 1809 or newer, then you have access to a windows ssh program called OpenSSH. More information about OpenSSH can be found [here](https://learn.microsoft.com/en-us/windows-server/administration/openssh/openssh_install_firstuse?tabs=gui).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should come first. If people have Win > 10, they don't need WSL, right (it currently seems to contradict the first sentence)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I'll go ahead and change that.

Changed the order of instructions in the "Windows Installation and Access" section + grammar
@stale
Copy link

stale bot commented Sep 20, 2023

This issue or pull request has been automatically marked as stale because it has not had recent activity. Please manually close it, if it is no longer relevant, or ask for help or support to help getting it unstuck. Let me bring this to the attention of @klieret @wdconinc @michmx for now.

@stale stale bot added the stale label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants