-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jjamidei patch 1 #34
base: gh-pages
Are you sure you want to change the base?
Jjamidei patch 1 #34
Conversation
…and Linux as well as made general edits to setup.md.
…ebpage into new-branch-1
Added "Windows/Mac/Linux Installation and Access" sections. Also changed link for "How to use Terminal on Mac" article to the "Unix Shell" software carpentry setup page (i.e. where the link was originally found).
Changed size of font for section titles
Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR. Much appreciated!
setup.md
Outdated
|
||
### Windows Installation and Access | ||
|
||
If you are using Windows, you will need to install [the Windows Subsystem for Linux (WSL)](https://learn.microsoft.com/en-us/windows/wsl/install). WSL will have the ssh programs you need by default, so once you've installed WSL you are ready for this tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that newer Windows systems have SSH pre-installed in the Windows shell and you can use it in the same way. However, I'm not sure how it behaves regarding configs and the like. But figuring that out and perhaps adding a note could be something to figure out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. Will look into and add whatever is relevant.
fig/ssh_connection.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to use this picture somewhere else? Because it doesn't seem to be referenced in the setup.md
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don´t think so. I'll double check with Amy, but I'm fairly certain that she made it for this tutorial specifically. I think she intended for it to be used on the Introduction page.
Added a brief section about OpenSSH for newer versions of windows as well as a link to Microsoft's page on getting started with OpenSSH.
for more information, see https://pre-commit.ci
setup.md
Outdated
|
||
If you are using a version of Windows, you will need to install [the Windows Subsystem for Linux (WSL)](https://learn.microsoft.com/en-us/windows/wsl/install). WSL will have the ssh programs you need by default, so once you've installed WSL you are ready for this tutorial. | ||
|
||
Note: If your version of Windows is either Windows 10 version 1809 or newer, then you have access to a windows ssh program called OpenSSH. More information about OpenSSH can be found [here](https://learn.microsoft.com/en-us/windows-server/administration/openssh/openssh_install_firstuse?tabs=gui). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should come first. If people have Win > 10, they don't need WSL, right (it currently seems to contradict the first sentence)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I'll go ahead and change that.
Changed the order of instructions in the "Windows Installation and Access" section + grammar
@klieret @pibion
Changed setup.md page to have installation instructions for windows, mac, and linux.