Update edition 2024 #1601
Open
Update edition 2024 #1601
+451
−502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Rust edition and apply changes required in the new edition. Also update the Cargo manifests to reflect the edition change, and ensure changes automatically apply to workspace members in the future.
The new Rust edition comes with some new formatting defaults, which need to be applied since the edition was increased.
|
Just wanted to try a Rust edition update to see how difficult or easy it is. I made a PR in case you'd like to accept this change since I now had the result of the update anyway. It was mostly for exploring this process myself, so feel free to close if you'd like to do the edition update yourself or at a later point in time 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Mostly followed the official migration guide, and did more builds/tests/... to make sure everything works fine after every step.
cargo updatecargo build(with all features, without default features, for all targets, various profiles, all workspaces...)cargo fix --edtion(for all features, all targets, for all workspaces...)Drop. The warnings mention that the new drop order is rarely a problem. Didn't change any of the code the warnings mentioned (later tests seem to suggest that everything works fine).expr_2021andunsafeforenv::set_var.if let ... else ...is also changed in a lot of places tomatchstatements. Doesn't seem to change functionality.Cargo.tomlfiles to share common options across workspace members (edition,authors,licenseandrepository). This ensures these options remain the same across workspace members during future edition updates.cargo build(with all features, without default features, for all targets, various profiles, all workspaces...)ncspotstill ran fine by logging in, navigating the UI and playing a song.cargo fmt --allIssue ticket number and link
/
Checklist before requesting a review
not performance improvements, etc.)