Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(worker): comment purpose of UI refresh task #1387

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ThomasFrans
Copy link
Contributor

The purpose of the manual ui refresh task isn't immediately clear. It was explained in the commit message of the commit that introduced it.

Describe your changes

Add a comment that explains the purpose of the refresh_ui task in the worker thread.

Checklist before requesting a review

  • Documentation was updated (i.e. due to changes in keybindings, commands, etc.)
  • Changelog was updated with relevant user-facing changes (eg. not dependency updates,
    not performance improvements, etc.)

The purpose of the manual UI refresh task isn't immediately clear. It
was explained in the commit message of the commit that introduced it.
@ThomasFrans
Copy link
Contributor Author

Stupidly small PR but I had to 'Git blame' to find what this was used for. Thought I'd add a comment in case others read this and didn't understand either. I assumed the player events were used to update the status bar.

@hrkfdn hrkfdn merged commit 8805464 into hrkfdn:main Feb 1, 2024
5 checks passed
@ThomasFrans ThomasFrans deleted the docs-refresh-task branch February 1, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants