Skip to content

Commit

Permalink
Use native TLS only, don't mix it with rustls
Browse files Browse the repository at this point in the history
reqwest uses native TLS, but rspotify with ureq currently uses rustls,
i.e. ncspot bundles rustls and is linked with system TLS library at the
same time.

This has already been fixed in 80da5a8,
but this commit has been reverted in
aeff120 due to a bug in rspotify that
was fixed in 0.13.1 (ramsayleung/rspotify#471).
  • Loading branch information
jirutka committed Apr 2, 2024
1 parent 7b3b541 commit 5a5e8b7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 69 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- All requests are correctly proxied when the relevant environment variables are set
- `ncspot` binary is simultaneously linked with the system TLS library (native-tls) and Rustls - only native-tls is used now

## [1.1.0] - 2024-03-05

Expand Down
70 changes: 2 additions & 68 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ signal-hook = "0.3.0"

[dependencies.rspotify]
default-features = false
features = ["client-ureq", "ureq-rustls-tls"]
features = ["client-ureq", "ureq-native-tls"]
version = "0.13.1"

[dependencies.cursive]
Expand Down

0 comments on commit 5a5e8b7

Please sign in to comment.