Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reporting): replace scenario_info.id_hash with uuid for an edge case bug on expand / collapse #171

Merged

Conversation

iamkenos
Copy link
Contributor

@iamkenos iamkenos commented Oct 17, 2024

Bug

There's an edge case where the html report scenarios' data-id-hash isnt created uniquely. I couldn't create a minimum reproducible example but it does happen on our project.

This is related to mutating the scenario names on runtime which we have done a fix for just recently.
image

One of the side effects of this is that when I expand / collapse one scenario, everything expands and collapses too.
expand-bug

Proposed Fix

Instead of creating a hash based on the scenario name and line, I replaced it with a uuid instead. I'm guessing that hash is supposed to be unique anyway.

image

PS

  • sorry to ask again 😅 but if the PR gets accepted, would very much appreciate the hacktoberfest-accepted label please. Thank you!

@hrcorval hrcorval changed the base branch from master to release_4.0.9 October 17, 2024 15:29
@hrcorval hrcorval merged commit 8ee6aea into hrcorval:release_4.0.9 Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants