display overview pyramid in browser

hpi-swa-teaching · Dec 21, 2024 · 5d187c9 · 5d187c9
1 parent 2749605
commit 5d187c9
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 7 deletions.
diff --git a/packages/SwaLintBrowser.package/SL2GlobalResult.class/instance/valueStringOrText.st b/packages/SwaLintBrowser.package/SL2GlobalResult.class/instance/valueStringOrText.st
@@ -0,0 +1,10 @@
+accessing
+valueStringOrText
+
+	self test testData key = #overviewPyramidMetric ifTrue:
+		[self resultData isError ifFalse:
+			[| results |
+			results := self resultData value.
+			^ Text string: Character startOfHeader asString attribute:
+				(OverviewPyramidMorph newWithResults: results) asContainer asTextAnchor]].
+	^ super valueStringOrText
diff --git a/packages/SwaLintBrowser.package/SL2GlobalResult.class/methodProperties.json b/packages/SwaLintBrowser.package/SL2GlobalResult.class/methodProperties.json
@@ -4,4 +4,5 @@
 	"instance" : {
 		"classObject" : "ct 12/12/2024 06:14",
 		"message" : "ct 12/12/2024 06:35",
-		"printOn:" : "ct 12/12/2024 06:35" } }
+		"printOn:" : "ct 12/12/2024 06:35",
+		"valueStringOrText" : "ct 12/21/2024 20:06" } }
diff --git a/packages/SwaLintBrowser.package/SL2Result.class/instance/valueStringOrText.st b/packages/SwaLintBrowser.package/SL2Result.class/instance/valueStringOrText.st
@@ -0,0 +1,4 @@
+accessing
+valueStringOrText
+
+	^ self valueString
diff --git a/packages/SwaLintBrowser.package/SL2Result.class/methodProperties.json b/packages/SwaLintBrowser.package/SL2Result.class/methodProperties.json
@@ -9,4 +9,5 @@
 		"resultData:" : "ct 12/12/2024 05:13",
 		"test" : "ct 12/12/2024 05:17",
 		"test:" : "ct 12/12/2024 05:17",
-		"valueString" : "ct 12/12/2024 06:35" } }
+		"valueString" : "ct 12/12/2024 06:35",
+		"valueStringOrText" : "ct 12/21/2024 19:52" } }
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/selectedMessage.st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/selectedMessage.st
@@ -4,7 +4,7 @@ selectedMessage
 
 	self hasMessageSelected ifFalse: [^ ''].
 	self selectedMessageName isSymbol ifFalse:
-		[^ self resultsForTestAndMessageSelection first valueString].
+		[^ self resultsForTestAndMessageSelection first valueStringOrText].
 	self selectedMessageName = #Definition ifTrue:
 		[^ self selectedClass "ifNotNil:" "#"definition].
 	^ super selectedMessage
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/testText.st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/testText.st
@@ -15,8 +15,8 @@ testText
 	resultsText := self hasMessageSelected ifTrue:
 		['<!--<b>Results:</b><br>-->{1}' asTextFromHtml format:
 			{(self resultsForTestAndMessageSelection
-				collect: [:result | '{1}: {2}' format: {result test title. result valueString}])
-					joinSeparatedBy: String cr}].
+				collect: [:result | '{1}: {2}' asText format: {result test title. result valueString}])
+					inject: Text new into: #,}].
 
 	^ Text streamContents: [:stream |
 		({resultsText. description} copyWithout: nil)

diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/methodProperties.json b/packages/SwaLintBrowser.package/SwaLintBrowser.class/methodProperties.json
@@ -79,7 +79,7 @@
 		"selectedClass" : "ct 12/17/2024 23:10",
 		"selectedClassIndex" : "ct 12/17/2024 23:11",
 		"selectedClassOrMetaClass" : "ct 12/18/2024 04:58",
-		"selectedMessage" : "ct 12/18/2024 04:48",
+		"selectedMessage" : "ct 12/21/2024 19:59",
 		"selectedMessageIndex" : "ct 12/18/2024 03:43",
 		"selectedMessageName" : "ct 12/17/2024 23:11",
 		"selectedTestNode" : "ct 12/18/2024 04:24",
@@ -101,7 +101,7 @@
 		"testNodePathFor:parent:" : "ct 12/18/2024 04:44",
 		"testRootPaths" : "ct 12/18/2024 04:43",
 		"testRoots" : "ct 12/18/2024 21:47",
-		"testText" : "ct 12/18/2024 03:00",
+		"testText" : "ct 12/21/2024 20:07",
 		"testTreeExpanded" : "ct 12/12/2024 06:22",
 		"tests" : "ct 12/12/2024 05:54",
 		"tests:" : "ct 12/12/2024 04:24",