Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add M2ColorSensor to handle color selection of pipette tool #67

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Add M2ColorSensor to handle color selection of pipette tool #67

wants to merge 3 commits into from

Conversation

maximilian-franz
Copy link
Contributor

@maximilian-franz maximilian-franz commented Jun 2, 2021 •
edited
Loading

Close #58

@maximilian-franz maximilian-franz self-assigned this Jun 2, 2021
@maximilian-franz maximilian-franz marked this pull request as draft June 2, 2021 20:03
@ClFeSc ClFeSc force-pushed the enhancement/58-pipette-tool branch from d7fac98 to 1cf7cbe Compare June 2, 2021 20:05
@ClFeSc ClFeSc force-pushed the enhancement/58-pipette-tool branch from c2c5913 to 9ba8960 Compare June 3, 2021 10:01
@maximilian-franz maximilian-franz marked this pull request as ready for review June 12, 2021 13:34
johannes-poetzsch
johannes-poetzsch requested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@johannes-poetzsch johannes-poetzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressing a button in MorphicMonet while selecting a color with the pipette will highlight that button despite not actually selecting it. As a result it looks as if a different tool is selected than it actually is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannes-poetzsch johannes-poetzsch johannes-poetzsch requested changes

@DevSchmidtchen DevSchmidtchen Awaiting requested review from DevSchmidtchen

@kpostnov kpostnov Awaiting requested review from kpostnov

@jannis-hpi jannis-hpi Awaiting requested review from jannis-hpi

@ClFeSc ClFeSc Awaiting requested review from ClFeSc

Assignees

@maximilian-franz maximilian-franz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipette-Tool blocks Squeak while selecting a color
2 participants
@maximilian-franz @johannes-poetzsch