specified missing parameters, specfied objects in loops, remove imple…

…mentation details in instance variables

Squello-Core.package/SPBAssignee.class/instance/id..st

@@ -1,4 +1,4 @@
 accessing
-id: anObject
+id: aNumber
 
-	id := anObject.
+	id := aNumber.

Squello-Core.package/SPBAssignee.class/instance/username..st

@@ -1,4 +1,4 @@
 accessing
-username: anObject
+username: aString
 
-	username := anObject.
+	username := aString.

Squello-Core.package/SPBAssignee.class/methodProperties.json

@@ -6,7 +6,7 @@
 		"asString" : "lo 5/28/2022 12:17",
 		"hash" : "LW 7/14/2022 11:23",
 		"id" : "lo 5/16/2022 22:43",
-		"id:" : "lo 5/16/2022 22:39",
+		"id:" : "tk 8/2/2022 23:42",
 		"isAssignee" : "lo 8/1/2022 14:48",
 		"username" : "lo 5/16/2022 22:42",
-		"username:" : "lo 5/16/2022 22:43" } }
+		"username:" : "tk 8/2/2022 23:42" } }

Squello-Core.package/SPBAuthenticationForm.class/instance/buildButtons..st

@@ -1,12 +1,12 @@
 toolbuilder
-buildButtons: builder
+buildButtons: aBuilder
 
-	^ {builder pluggableButtonSpec new
+	^ {aBuilder pluggableButtonSpec new
 			model: self; 
 			label: 'Submit';
 			action: #actionSaveAndClose;
 			yourself.
-		builder pluggableButtonSpec new
+		aBuilder pluggableButtonSpec new
 			model: self; 
 			label: 'Cancel';
 			action: #actionCancel;

Squello-Core.package/SPBAuthenticationForm.class/instance/buildInputFields..st

@@ -1,14 +1,14 @@
 toolbuilder
-buildInputFields: builder
+buildInputFields: aBuilder
 
-	^ {builder pluggableInputFieldSpec new
+	^ {aBuilder pluggableInputFieldSpec new
 			model: self;
 			getText: #actionUsername;
 			editText: #actionUsername:;
 			setText: #actionUsername:;
 			help: 'GitHub username.';
 			yourself.
-		builder pluggableInputFieldSpec new
+		aBuilder pluggableInputFieldSpec new
 			model: self;
 			font: (StrikeFont passwordFontSize: 12);
 			getText: #actionToken;

Squello-Core.package/SPBAuthenticationForm.class/instance/buildInputPanel..st

@@ -1,9 +1,9 @@
 toolbuilder
-buildInputPanel: builder
+buildInputPanel: aBuilder
 
-	^ builder pluggablePanelSpec new
+	^ aBuilder pluggablePanelSpec new
 		model: self;
 		layout: #vertical;
-		children: (self buildInputFields: builder);
+		children: (self buildInputFields: aBuilder);
 		frame: (0@0 corner: 1@1);
 		yourself.

Squello-Core.package/SPBAuthenticationForm.class/instance/buildWith..st

@@ -1,12 +1,12 @@
 toolbuilder
-buildWith: builder
+buildWith: aBuilder
 
-	^ builder build: (builder pluggableDialogSpec new
+	^ aBuilder build: (aBuilder pluggableDialogSpec new
 			model: self;
 			label: #labelString;
 			extent: 600@60;
 			exclusive: false;
 			message: 'Insert GitHub authentication data:';
-			children: {self buildInputPanel: builder};
-			buttons: (self buildButtons: builder);
+			children: {self buildInputPanel: aBuilder};
+			buttons: (self buildButtons: aBuilder);
 			yourself).

Squello-Core.package/SPBAuthenticationForm.class/methodProperties.json

@@ -8,10 +8,10 @@
 		"actionToken:" : "lo 7/13/2022 19:25",
 		"actionUsername" : "lo 7/13/2022 19:21",
 		"actionUsername:" : "lo 7/13/2022 19:25",
-		"buildButtons:" : "mcr 8/2/2022 16:48",
-		"buildInputFields:" : "lo 8/1/2022 14:19",
-		"buildInputPanel:" : "lo 8/1/2022 14:19",
-		"buildWith:" : "lo 8/1/2022 10:51",
+		"buildButtons:" : "tk 8/2/2022 23:42",
+		"buildInputFields:" : "tk 8/2/2022 23:42",
+		"buildInputPanel:" : "tk 8/2/2022 23:42",
+		"buildWith:" : "tk 8/2/2022 23:43",
 		"checkUserValid" : "lo 7/13/2022 19:16",
 		"close" : "lo 8/1/2022 14:16",
 		"labelString" : "lo 7/13/2022 19:29",

Squello-Core.package/SPBBoard.class/instance/addColumn.st

@@ -7,7 +7,7 @@ addColumn
 		ifTrue: [^ self].
 	[column := self boardProvider createColumn: prompt]
 		on: Error
-		do: [:ex | ^ self errorCannotAddColumn: ex messageText].
+		do: [:error | ^ self errorCannotAddColumn: error messageText].
 
 	column 
 		board: self;

Squello-Core.package/SPBBoard.class/instance/buildColumnSpecWith..st

@@ -1,4 +1,4 @@
 toolbuilder
 buildColumnSpecWith: aBuilder
 
-	^ self columns collect: [:each | self buildColumnSpecWith: aBuilder and: each].
+	^ self columns collect: [:column | self buildColumnSpecWith: aBuilder and: column].

Squello-Core.package/SPBBoard.class/methodProperties.json

@@ -9,7 +9,7 @@
 		"registerInAppsMenu" : "lo 6/4/2022 23:19" },
 	"instance" : {
 		"activeCard" : "mcr 8/1/2022 02:31",
-		"addColumn" : "lo 8/1/2022 14:20",
+		"addColumn" : "tk 8/2/2022 23:31",
 		"boardProvider" : "jh 7/29/2022 11:34",
 		"boardProvider:" : "lo 7/31/2022 16:32",
 		"buildAddColumnButtonPanelSpecWith:" : "lo 8/1/2022 13:41",
@@ -24,7 +24,7 @@
 		"buildColumnHeaderMoveColumnButtonSpecWith:and:" : "lo 8/1/2022 11:02",
 		"buildColumnHeaderSpecWith:and:" : "lo 8/1/2022 11:02",
 		"buildColumnHeaderTitleSpecWith:and:" : "lo 8/1/2022 11:04",
-		"buildColumnSpecWith:" : "mcr 8/1/2022 02:18",
+		"buildColumnSpecWith:" : "tk 8/2/2022 23:32",
 		"buildColumnSpecWith:and:" : "lo 8/1/2022 13:42",
 		"buildSidebarAssigneeListSpecWith:" : "lo 8/1/2022 11:06",
 		"buildSidebarAssigneePanelSpecWith:" : "lo 8/1/2022 11:06",

Squello-Core.package/SPBCard.class/instance/addAssigneeLocal..st

@@ -1,7 +1,7 @@
 updating-local
 addAssigneeLocal: anSPBAssignee
 
-	(self assignees anySatisfy: [:each | each = anSPBAssignee]) 
+	(self assignees anySatisfy: [:assignee | assignee = anSPBAssignee]) 
 		ifTrue: [^ self].
 
 	self assignees add: anSPBAssignee.

Squello-Core.package/SPBCard.class/instance/addLabelLocal..st

@@ -1,7 +1,7 @@
 updating-local
 addLabelLocal: anSPBLabel
 
-	(self labels anySatisfy: [:each | each = anSPBLabel]) 
+	(self labels anySatisfy: [:label | label = anSPBLabel]) 
 		ifTrue: [^ self].
 
 	self labels add: anSPBLabel.

Squello-Core.package/SPBCard.class/instance/alignLabels.st

@@ -2,8 +2,8 @@ updating-local
 alignLabels
 
 	| previousLabel |
-	self labelMorphs
+	self labelModels
 		withIndexDo: [ :label :index | index = 1
-				ifTrue: [label position: self labelBorderOffset @ (self position y + self titleMorph extent y + self labelTitleOffset)]
-				ifFalse: [previousLabel := self labelMorphs at: index - 1.
+				ifTrue: [label position: self labelBorderOffset @ (self position y + self titleModel extent y + self labelTitleOffset)]
+				ifFalse: [previousLabel := self labelModels at: index - 1.
 					label position: self labelBorderOffset @ (previousLabel position y + (previousLabel extent y + self inbetweenLabelOffset))]]

Squello-Core.package/SPBCard.class/instance/assigneeModel..st

@@ -0,0 +1,4 @@
+accessing
+assigneeModel: aTextMorph
+
+	assigneeModel := aTextMorph.

Squello-Core.package/SPBCard.class/instance/assigneeModel.st

@@ -0,0 +1,4 @@
+accessing
+assigneeModel
+
+	^ assigneeModel.

Squello-Core.package/SPBCard.class/instance/buildAssignee.st

@@ -8,4 +8,4 @@ buildAssignee
 
 	self
 		addMorph: assigneeMorph;
-		assigneeMorph: assigneeMorph.
+		assigneeModel: assigneeMorph.

Squello-Core.package/SPBCard.class/instance/buildIndicatorDetection.st

@@ -3,16 +3,16 @@ buildIndicatorDetection
 
 	| extent |
 	extent := self extent.
-	self upperHalfMorph: (self buildIndicatorDetectionHalf
-		position: self position - (0 @  SPBColumn defaultSpaceBetweenCards);
+	self upperHalfIndicator: (self buildIndicatorDetectionHalf
+		position: self position - (0@  SPBColumn defaultSpaceBetweenCards);
 		location: #upper;
 		yourself).
 
-	self lowerHalfMorph: (self buildIndicatorDetectionHalf
-		position: self position x + (0 @ (extent y / 2));
+	self lowerHalfIndicator: (self buildIndicatorDetectionHalf
+		position: self position x + (0@ (extent y / 2));
 		location: #lower;
 		yourself).
 
 	self
-		addMorph: self upperHalfMorph;
-		addMorph: self lowerHalfMorph.
+		addMorph: self upperHalfIndicator;
+		addMorph: self lowerHalfIndicator.

Squello-Core.package/SPBCard.class/instance/buildTitle.st

@@ -9,5 +9,5 @@ buildTitle
 		yourself.
 
 	self
-		titleMorph: titleMorph;
+		titleModel: titleMorph;
 		addMorph: titleMorph.

Squello-Core.package/SPBCard.class/instance/labelModels..st

@@ -0,0 +1,4 @@
+accessing
+labelModels: aCollection
+
+	labelModels := aCollection.

Squello-Core.package/SPBCard.class/instance/labelModels.st

@@ -0,0 +1,4 @@
+accessing
+labelModels
+
+	^ labelModels ifNil: [labelModels := OrderedCollection new].

Squello-Core.package/SPBCard.class/instance/lowerHalfIndicator..st

@@ -0,0 +1,4 @@
+accessing
+lowerHalfIndicator: anSPBIndicatorDetectionCard
+
+	lowerHalfIndicator := anSPBIndicatorDetectionCard.

Squello-Core.package/SPBCard.class/instance/lowerHalfIndicator.st

@@ -0,0 +1,4 @@
+accessing
+lowerHalfIndicator
+
+	^ lowerHalfIndicator.

Squello-Core.package/SPBCard.class/instance/resizeCard.st

@@ -2,7 +2,7 @@ updating-local
 resizeCard
 
 	self setCardHeight.
-	self assigneeMorph position: self position + self extent - self assigneeOffset.
+	self assigneeModel position: self position + self extent - self assigneeOffset.
 	self column 
 		alignCards;
 		resizeBottomDetection.

Squello-Core.package/SPBCard.class/instance/resizeIndicatorFields.st

@@ -1,8 +1,8 @@
 updating-local
 resizeIndicatorFields
 
-	self upperHalfMorph 
+	self upperHalfIndicator 
 		extent: self cardIndicatorExtent.
-	self lowerHalfMorph 
-		position: self position + (0 @ self extent y / 2);
+	self lowerHalfIndicator 
+		position: self position + (0@ self extent y / 2);
 		extent: self cardIndicatorExtent.

Squello-Core.package/SPBCard.class/instance/setCardHeight.st

@@ -3,6 +3,6 @@ setCardHeight
 
 	| labelHeightsSum |
 	labelHeightsSum := 0.
-	self labelMorphs
+	self labelModels
 		do: [:label | labelHeightsSum := labelHeightsSum + label extent y + self inbetweenLabelOffset].
-	self extent: self class defaultCardExtent x @ ((self titleMorph extent y + labelHeightsSum + self labelTitleOffset) max: self class defaultCardExtent y).
+	self extent: self class defaultCardExtent x @ ((self titleModel extent y + labelHeightsSum + self labelTitleOffset) max: self class defaultCardExtent y).

Squello-Core.package/SPBCard.class/instance/titleModel..st

@@ -0,0 +1,4 @@
+accessing
+titleModel: aTextMorph
+
+	titleModel := aTextMorph.

Squello-Core.package/SPBCard.class/instance/titleModel.st

@@ -0,0 +1,4 @@
+accessing
+titleModel
+
+	^ titleModel.

Squello-Core.package/SPBCard.class/instance/updateAssigneeCount.st

@@ -3,6 +3,6 @@ updateAssigneeCount
 
 	| count |
 	count := self assignees size.
-	self assigneeMorph contents: count asString , ' assigned'.
+	self assigneeModel contents: count asString , ' assigned'.
 	self updateBalloonText.
 

Squello-Core.package/SPBCard.class/instance/updateBalloonText.st

@@ -7,6 +7,6 @@ updateBalloonText
 			^ self].
 	text := 'Assignees:', Character cr.
 	self assignees 
-		do: [:each | text := text, each asString, Character cr].
+		do: [:assignee | text := text, assignee asString, Character cr].
 	self balloonText: text.
 

Squello-Core.package/SPBCard.class/instance/updateLabelIcons.st

@@ -2,13 +2,13 @@ updating-local
 updateLabelIcons
 
 	| newLabel |
-	self labelMorphs
-		do: [:each | each abandon].
-	self labelMorphs: OrderedCollection new.
+	self labelModels
+		do: [:label | label abandon].
+	self labelModels: OrderedCollection new.
 
 	self labels 
 		do: [:label | newLabel := label asMorph.
-			self labelMorphs add: newLabel.
+			self labelModels add: newLabel.
 			self addMorph: newLabel.
 			self alignLabels].
 	self column

Squello-Core.package/SPBCard.class/instance/updateTitle..st

@@ -3,7 +3,7 @@ updateTitle: aString
 
 	self title == aString 
 		ifFalse: [self title: aString.
-			self titleMorph contents: aString.
+			self titleModel contents: aString.
 			self boardProvider updateCard: self.
 			self updateLabelIcons.
 			self resizeCard].

Squello-Core.package/SPBCard.class/instance/upperHalfIndicator..st

@@ -0,0 +1,4 @@
+accessing
+upperHalfIndicator: anSPBIndicatorDetectionCard
+
+	upperHalfIndicator := anSPBIndicatorDetectionCard.