Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll ids #258

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Poll ids #258

merged 7 commits into from
Jun 12, 2024

Conversation

leaantonia
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9482118471

Details

  • 16 of 22 (72.73%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.1%) to 76.073%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-UI.package/LQStartMenu.class/instance/enterParticipantMode.st 0 6 0.0%
Totals Coverage Status
Change from base Build 9438278446: -2.1%
Covered Lines: 2321
Relevant Lines: 3051
💛 - Coveralls

@leaantonia leaantonia requested a review from vlindow June 12, 2024 12:08
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9482260007

Details

  • 16 of 38 (42.11%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.3%) to 75.899%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-UI.package/LQStartMenu.class/instance/getPollIdFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/getUrlFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/enterParticipantMode.st 0 16 0.0%
Totals Coverage Status
Change from base Build 9438278446: -2.3%
Covered Lines: 2321
Relevant Lines: 3058
💛 - Coveralls

@leaantonia leaantonia closed this Jun 12, 2024
@leaantonia leaantonia reopened this Jun 12, 2024
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9482259806

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.9%) to 89.111%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-UI.package/LQStartMenu.class/instance/getPollIdFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/getUrlFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/enterParticipantMode.st 0 16 0.0%
Totals Coverage Status
Change from base Build 9438278446: 10.9%
Covered Lines: 2725
Relevant Lines: 3058
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9482495394

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.4%) to 75.773%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-UI.package/LQStartMenu.class/instance/getPollIdFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/getUrlFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/enterParticipantMode.st 0 16 0.0%
Totals Coverage Status
Change from base Build 9438278446: -2.4%
Covered Lines: 2305
Relevant Lines: 3042
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9482506267

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.4%) to 75.773%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-UI.package/LQStartMenu.class/instance/getPollIdFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/getUrlFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/enterParticipantMode.st 0 16 0.0%
Totals Coverage Status
Change from base Build 9438278446: -2.4%
Covered Lines: 2305
Relevant Lines: 3042
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9482494838

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.9%) to 89.053%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-UI.package/LQStartMenu.class/instance/getPollIdFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/getUrlFrom.with..st 0 3 0.0%
packages/Liquid-UI.package/LQStartMenu.class/instance/enterParticipantMode.st 0 16 0.0%
Totals Coverage Status
Change from base Build 9438278446: 10.9%
Covered Lines: 2709
Relevant Lines: 3042
💛 - Coveralls

vlindow
vlindow approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@vlindow vlindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@vlindow vlindow merged commit 20a1941 into develop Jun 12, 2024
2 of 11 checks passed
@florian-str florian-str deleted the pollIds branch June 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlindow vlindow vlindow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leaantonia @coveralls @vlindow