Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll ids #253

Closed
wants to merge 5 commits into from
Closed

Poll ids #253

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d79442f
simpler ids and default url
leaantonia Jun 3, 2024
8056a14
one window for entering server and id
leaantonia Jun 4, 2024
67c08d7
shorterids
leaantonia Jun 5, 2024
c5ff3fc
prettyprint
leaantonia Jun 5, 2024
28361e6
random generator
leaantonia Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/generateIdFromNumbers.st
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Try to avoid repetition here. Maybe look into the Random class (nextInt) of squeak to generate the ID.
  • apply prettyPrint formatting (remove blank line)

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
generation
generateIdFromNumbers

^ ((self randomNumber),
(self randomNumber),
(self randomNumber),
(self randomNumber),
(self randomNumber))
6 changes: 0 additions & 6 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/generateIdFromRealWords.st
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/randomNumber.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
generation
randomNumber

^ self storedNumbers atRandom
4 changes: 0 additions & 4 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/randomObject.st
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/randomSubject.st
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/randomVerb.st
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/storedNumbers.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
generation
storedNumbers
^ {'1'. '2'. '3'. '4'. '5'. '6'. '7'. '8'. '9'}

47 changes: 0 additions & 47 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/storedObjects.st
View file
Open in desktop

This file was deleted.

215 changes: 0 additions & 215 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/storedSubjects.st
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/instance/storedVerbs.st
View file
Open in desktop

This file was deleted.

10 changes: 3 additions & 7 deletions packages/Liquid-Core.package/LQPollIdGenerator.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
"class" : {
},
"instance" : {
"generateIdFromRealWords" : "JT 8/4/2022 21:39",
"randomObject" : "JT 8/2/2022 17:14",
"randomSubject" : "JT 8/2/2022 17:14",
"randomVerb" : "JT 8/2/2022 17:14",
"storedObjects" : "JT 8/2/2022 17:18",
"storedSubjects" : "JT 8/2/2022 17:18",
"storedVerbs" : "JT 8/2/2022 17:18" } }
"generateIdFromNumbers" : "leli 6/5/2024 15:21",
"randomNumber" : "leli 6/3/2024 17:11",
"storedNumbers" : "leli 6/5/2024 16:56" } }
9 changes: 0 additions & 9 deletions packages/Liquid-Tests.package/LQRandomIdGeneratorTests.class/instance/testLowercase.st
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/Liquid-Tests.package/LQRandomIdGeneratorTests.class/instance/testUniqueness.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ testUniqueness

generator := LQPollIdGenerator new.

self assert: false equals: ((generator generateIdFromRealWords) == (generator generateIdFromRealWords))
self assert: false equals: ((generator generateIdFromNumbers) == (generator generateIdFromNumbers))
3 changes: 1 addition & 2 deletions packages/Liquid-Tests.package/LQRandomIdGeneratorTests.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@
"class" : {
},
"instance" : {
"testLowercase" : "JT 8/2/2022 17:56",
"testUniqueness" : "JT 8/2/2022 17:56" } }
"testUniqueness" : "leli 6/3/2024 17:12" } }
2 changes: 1 addition & 1 deletion packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/generateRandomID.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
supporting
generateRandomID

^ LQPollIdGenerator new generateIdFromRealWords
^ LQPollIdGenerator new generateIdFromNumbers
2 changes: 1 addition & 1 deletion packages/Liquid-UI.package/LQPollDraftBuilder.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"currentQuestion" : "bn 8/2/2022 16:58",
"currentQuestion:" : "bn 6/23/2022 22:15",
"frame:fromTop:fromLeft:width:" : "bn 8/2/2022 16:58",
"generateRandomID" : "JT 6/23/2022 19:34",
"generateRandomID" : "leli 6/3/2024 17:12",
"getIndex" : "bn 8/2/2022 16:58",
"initialize" : "bn 6/27/2022 13:49",
"list" : "bn 8/2/2022 16:58",
Expand Down
Loading
Loading