-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/csv export #249
Bugfix/csv export #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the CSV export works as expected, there are some minor issues regarding code quality and usability.
packages/Liquid-UI.package/LQHostMenu.class/instance/showResults.st
Outdated
Show resolved
Hide resolved
packages/Liquid-Core.package/LQPoll.class/instance/exportCSV.st
Outdated
Show resolved
Hide resolved
packages/Liquid-Core.package/LQPoll.class/instance/returnDataWithDelimiter..st
Outdated
Show resolved
Hide resolved
packages/Liquid-Core.package/LQStringProcessor.class/class/replaceAll.in..st
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the feature is working as intended and the code looks clean.
Thanks for your contribution.
Pull Request Test Coverage Report for Build 9337737887Details
💛 - Coveralls |
This pull request fixes an issue with the csv export (#210 ). It is now possible to export the results to a csv file by clicking the "Export Results" button in the Liquid host menu.