Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/csv export #249

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Bugfix/csv export #249

merged 8 commits into from
Jun 3, 2024

Conversation

vlindow
Copy link
Contributor

@vlindow vlindow commented May 29, 2024

This pull request fixes an issue with the csv export (#210 ). It is now possible to export the results to a csv file by clicking the "Export Results" button in the Liquid host menu.

Copy link
Contributor

@florian-str florian-str left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the CSV export works as expected, there are some minor issues regarding code quality and usability.

@florian-str florian-str requested a review from leaantonia June 2, 2024 08:50
Copy link
Contributor

@florian-str florian-str left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the feature is working as intended and the code looks clean.

Thanks for your contribution.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9337737887

Details

  • 30 of 46 (65.22%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 90.123%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-Core.package/LQPoll.class/instance/returnDataWithDelimiter..st 0 6 0.0%
packages/Liquid-UI.package/LQHostMenu.class/instance/exportResults.st 0 10 0.0%
Totals Coverage Status
Change from base Build 9337061323: 1.0%
Covered Lines: 3002
Relevant Lines: 3331

💛 - Coveralls

@leaantonia leaantonia merged commit 9e3b055 into develop Jun 3, 2024
0 of 14 checks passed
@florian-str florian-str deleted the bugfix/csv_export branch June 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants