Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete question #242

Merged
merged 5 commits into from
May 28, 2024
Merged

Feature/delete question #242

merged 5 commits into from
May 28, 2024

Conversation

vlindow
Copy link
Contributor

@vlindow vlindow commented May 21, 2024

This pull request adds the delete button for questions as described in #237

@coveralls
Copy link

coveralls commented May 21, 2024

Pull Request Test Coverage Report for Build 9253529973

Details

  • 24 of 34 (70.59%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.0%) to 89.093%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/removeQuestionBuilderAt..st 0 3 0.0%
packages/Liquid-UI.package/LQPollDraftBuilder.class/instance/removeQuestion.st 0 7 0.0%
Totals Coverage Status
Change from base Build 9235219489: 10.0%
Covered Lines: 2957
Relevant Lines: 3319

💛 - Coveralls

@florian-str
Copy link
Contributor

The functionality looks good. However, the code formatting was not properly applied.

@florian-str florian-str merged commit 41c954c into develop May 28, 2024
0 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants