-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike for 'context sensitive actions' #222
Draft
TheGrayStone
wants to merge
23
commits into
development
Choose a base branch
from
spike/context-sensitive-actions
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checkboxes there
TheGrayStone
changed the title
Spike/context sensitive actions
Spike for 'context sensitive actions'
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, this works with only this small change 👍
There are some things that I noticed though (mostly no must-haves for this spike):
- the keyboard focus is reset to the end of the input field after a second or so, so moving to the beginning of the input is virtually impossible. We've got to come up with something better than just
moveCursorToEnd
(same goes for say selecting some text) - the above problem also means that the text is unselected very quickly when you open algernon, so you usually start appending to your last query instead of overwriting it
- when activating algernon while hovering over an entry of a right-click-menu, the menu disappears, but algernon doesn't get keyboard focus, so neither querying nor closing with esc work. one can click into the input field to fix that glitch
- I think we want to have separate icons for these actions. Otherwise, lots of results have the world icon. in my opinion, having these results as their own type seems appropriate in any case
- do we know that all of the context menus consist of
MenuMorph
s? - results from the second page (after you click "more") are not included, for example "inspect subinstances". with the current approach, I don't really see us finding these any time soon though (and it isn't really a must, not even for the first release of this feature imo)
- talking about the approach: while it is very direct and effective, I wonder if we could only "fetch" the results from the normal provider that is used by the browser (<= really assuming some architecture of the system browser right here). "clicking around" in the world on every keypress doesn't sound very safe. Are there any scenarios where right-clicking actually really does something meaningful (more than the example above)? That would be pretty bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #208
This is based on the reworked menu item structure