Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike for 'context sensitive actions' #222

Draft
wants to merge 23 commits into
base: development
Choose a base branch
from

Conversation

TheGrayStone
Copy link
Contributor

@TheGrayStone TheGrayStone commented Jul 7, 2021

closes #208

This is based on the reworked menu item structure

@TheGrayStone TheGrayStone changed the base branch from development to feat/world-submenu July 7, 2021 16:18
@TheGrayStone TheGrayStone changed the title Spike/context sensitive actions Spike for 'context sensitive actions' Jul 8, 2021
Copy link
Contributor

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, this works with only this small change 👍

There are some things that I noticed though (mostly no must-haves for this spike):

  • the keyboard focus is reset to the end of the input field after a second or so, so moving to the beginning of the input is virtually impossible. We've got to come up with something better than just moveCursorToEnd (same goes for say selecting some text)
  • the above problem also means that the text is unselected very quickly when you open algernon, so you usually start appending to your last query instead of overwriting it
  • when activating algernon while hovering over an entry of a right-click-menu, the menu disappears, but algernon doesn't get keyboard focus, so neither querying nor closing with esc work. one can click into the input field to fix that glitch
  • I think we want to have separate icons for these actions. Otherwise, lots of results have the world icon. in my opinion, having these results as their own type seems appropriate in any case
  • do we know that all of the context menus consist of MenuMorphs?
  • results from the second page (after you click "more") are not included, for example "inspect subinstances". with the current approach, I don't really see us finding these any time soon though (and it isn't really a must, not even for the first release of this feature imo)
  • talking about the approach: while it is very direct and effective, I wonder if we could only "fetch" the results from the normal provider that is used by the browser (<= really assuming some architecture of the system browser right here). "clicking around" in the world on every keypress doesn't sound very safe. Are there any scenarios where right-clicking actually really does something meaningful (more than the example above)? That would be pretty bad

Base automatically changed from feat/world-submenu to development July 14, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate context-sensitive actions
2 participants