-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted Markdown content styling #679
base: master
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for hpe-dev-portal ready! 🔨 Explore the source changes: 308ea1c 🔍 Inspect the deploy log: https://app.netlify.com/sites/hpe-dev-portal/deploys/6126afbc3f002a0007890a24 😎 Browse the preview: https://deploy-preview-679--hpe-dev-portal.netlify.app |
@ericsoderberghp LGTM! ✅ |
Hi @ericsoderberghp, I was talking with Didier and we wondering the reason behind pushing the content more the left and freeing up space to the right, thus making the content more narrow. This will be something that I will bring up with the team. |
Hey, sure. The motivation was that wider paragraphs reduce accessibility because it's harder to scan backwards to determine where the beginning of the next line is as you are reading it. The grommet Paragraph component has that built into it, tied to the font size. We provide |
Thanks @ericsoderberghp for the explanation! We will bring this up to the team next week and will get back to you. |
Hi @ericsoderberghp, sorry about the late response. We are good to implement this 👍 There are just 2 issues we noticed:
Before:
|
Hi @ericsoderberghp, just a friendly reminder to see if you have had a chance to see the comment above. Thanks! |
Ah, yes. Glad you poked me. I can't this week, hopefully next week. Thanks for the good feedback. |
Here are some styling tweaks to give just a bit more spacing and alignment to the text content.