WIP: Cleaning up the CLI mess stack #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itkovian
force-pushed
the
split-nrpe-convenience-methods
branch
from
5c9dbb0 to
076ce72
Compare
|
This is ready for a review, but should not yet be merged. |
wdpypere
reviewed
Feb 18, 2025
| """Return the script name without .py extension if any. This assumes that the script name does not contain a | ||
| dot in case of lacking an extension. | ||
| """ | ||
| (name, _) = os.path.splitext(full_name) |
wdpypere
reviewed
Feb 18, 2025
|
|
||
| import os | ||
| import warnings | ||
| from functools import wraps |
wdpypere
reviewed
Feb 18, 2025
| NAGIOS_CACHE_FILENAME_TEMPLATE % (_script_name(sys.argv[0]),) | ||
| ) | ||
| ), | ||
| 'nagios-check-interval-threshold': ('threshold of nagios checks timing out', 'int', 'store', 0), |
There was a problem hiding this comment.
I still don't know what this does, thresholds are configured in icinga, not in checks.
wdpypere
reviewed
Feb 18, 2025
| 'nagios-report': ('print out nagios information', None, 'store_true', False, 'n'), | ||
| 'nagios-check-filename': | ||
| ('filename of where the nagios check data is stored', 'str', 'store', | ||
| os.path.join( |
wdpypere
reviewed
Feb 18, 2025
| Set the log level | ||
| """ | ||
| if self.options.quiet: | ||
| logging.basicConfig(level=logging.WARNING) |
There was a problem hiding this comment.
I see a mixture of fancylogger and regular logging, most of the time that does not work (e.g. one or the other get's lost.) has this been tested?
wdpypere
reviewed
Feb 18, 2025
| Convenience method that exists with nagios unknown exitcode | ||
| """ | ||
| exit_from_errorcode(3, msg) | ||
| # def ok(self, msg): |
There was a problem hiding this comment.
why are these in comment?
wdpypere
reviewed
Feb 18, 2025
| @@ -408,30 +753,32 @@ def main(self): | |||
| self.fulloptions.epilogue(f"{msg} complete", self.thresholds) | |||
|
|
|||
|
|
|||
| @deprecated_class("Base your scripts on the CLIBase class instead") | |||
| class NrpeCLI(CLI): | |||
There was a problem hiding this comment.
why are these deprecated?
|
@itkovian as discussed, can we get an overview of what we are trying to achieve and the problems we are trying to solve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code to a new stack such that we can ditch a lot of obsolete code that was once introduced to deal with py 2.[47] shortcomings.
postmethod