Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade eclwatch to v3 #4295

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: Upgrade eclwatch to v3 #4295

merged 1 commit into from
Nov 13, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Nov 13, 2024 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg November 13, 2024 13:39
jeclrsg
jeclrsg reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith looks good. just one question about that ip in the spec file. should those tests use play.hpccsystems.com or localhost or something?

packages/eclwatch/tests/eclwatch.browser.spec.ts Outdated

const urlSearch: string = window.location.href.split("?")[1];

const ESP_URL = "http://52.210.14.156:8010/";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this ip?

@GordonSmith
feat: Upgrade eclwatch to v3
a32c104 
Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith
Copy link
Member Author

FWIW I think the tests just initialize the classes and don't make any server calls.

@GordonSmith GordonSmith merged commit d8d4ae6 into hpcc-systems:candidate-3.x.x Nov 13, 2024
4 checks passed
@GordonSmith GordonSmith deleted the V3_ECLWATCH branch November 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg