Merge pull request #16851 from kenrowland/HPCC-28789

HPCC-28789 Keep ESP service execution profile enable per defined service Reviewed-By: Anthony Fishbeck [email protected] Merged-by: Gavin Halliday <[email protected]>
hpcc-systems · Jan 24, 2023 · 74bd46a · 74bd46a
2 parents 52cafb9 + 8719496
commit 74bd46a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 16 deletions.
diff --git a/tools/hidl/hidlcomp.cpp b/tools/hidl/hidlcomp.cpp
@@ -7143,11 +7143,7 @@ void HIDLcompiler::processExecutionProfiling()
     for (si=servs; si; si=si->next)
     {
         StrBuffer serviceProfilingOptions;
-        bool serviceProfileExecutionEnabled = si->getMetaStringValue(serviceProfilingOptions,"profile_execution");
-
-        //
-        // At the HIDL top level, execution profiling is enabled if any service is enabled
-        executionProfilingEnabled |= serviceProfileExecutionEnabled;
+        si->executionProfilingEnabled = si->getMetaStringValue(serviceProfilingOptions,"profile_execution");
 
         //
         // Go through each method and save any profile information to make if faster later when
@@ -7160,8 +7156,8 @@ void HIDLcompiler::processExecutionProfiling()
             // Collect method profile execution values
             StrBuffer methodProfilingOptions;
             bool methodProfileExecutionEnabled = mthi->getMetaStringValue(methodProfilingOptions, "profile_execution");
-            executionProfilingEnabled |= methodProfileExecutionEnabled;   // again, if a method is enabled, set top flag
-            if (serviceProfileExecutionEnabled || methodProfileExecutionEnabled)
+            si->executionProfilingEnabled |= methodProfileExecutionEnabled;   // again, if a method is enabled, set top flag
+            if (si->executionProfilingEnabled || methodProfileExecutionEnabled)
             {
                 if (!mthi->getMetaInt("no_profile_execution"))
                 {
@@ -7185,11 +7181,18 @@ void HIDLcompiler::write_esp()
     outf("#define %s_ESPGEN_INCLUDED\n\n", packagename);
     outf("#include \"%s_esp.ipp\"\n", packagename);
 
-    if (executionProfilingEnabled)
+    // If any defined service has execution profiling enabled, add the required includes
+    EspServInfo *si;
+    for (si=servs;si;si=si->next)
     {
-        outs("#include \"espcommon.hpp\"\n");
-        outs("#include \"jmetrics.hpp\"\n");
+        if (si->executionProfilingEnabled)
+        {
+            outs("#include \"espcommon.hpp\"\n");
+            outs("#include \"jmetrics.hpp\"\n");
+            break;
+        }
     }
+
     outs("\n");
     outs("#ifdef _WIN32\n");
     outs("#include \"edwin.h\"\n");
@@ -7204,7 +7207,6 @@ void HIDLcompiler::write_esp()
         mi->write_esp();
     }
 
-    EspServInfo *si;
     for (si=servs;si;si=si->next)
     {
         si->write_esp_binding();
@@ -7252,10 +7254,15 @@ void HIDLcompiler::write_esp_ex_ipp()
     outs("\n\n");
 
     // metrics execution profiling requires the memory header
-    if (executionProfilingEnabled)
+    EspServInfo *si;
+    for (si=servs;si;si=si->next)
     {
-        outs("#include <memory>\n");
-        outs("\n\n");
+        if (si->executionProfilingEnabled)
+        {
+            outs("#include <memory>\n");
+            outs("\n\n");
+            break;
+        }
     }
 
     outf("namespace %s\n{\n\n", packagename);
@@ -7266,7 +7273,6 @@ void HIDLcompiler::write_esp_ex_ipp()
         mi->write_esp_ipp();
     }
 
-    EspServInfo *si;
     for (si=servs;si;si=si->next)
     {
         si->write_esp_service_ipp();

diff --git a/tools/hidl/hidlcomp.h b/tools/hidl/hidlcomp.h
@@ -1185,6 +1185,9 @@ class EspServInfo
     char        *base_;
     bool needsXslt;
 
+public:
+    bool executionProfilingEnabled = false;
+
 
 public:
     EspServInfo(const char *name)
@@ -1335,7 +1338,6 @@ class HIDLcompiler
     EspMessageInfo *msgs;
     EspServInfo *servs;
     IncludeInfo *includes;
-    bool executionProfilingEnabled = false;
 };