Skip to content

Commit

Permalink
Merge pull request #17250 from ghalliday/issue28817
Browse files Browse the repository at this point in the history
HPCC-28817 Remove unnecessary TxSummary warning log entry

Reviewed-By: Rodrigo Pastrana <[email protected]>
Merged-by: Gavin Halliday <[email protected]>
  • Loading branch information
ghalliday authored Apr 17, 2023
2 parents 0f4a67f + 99bc852 commit 1024fa0
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions esp/platform/txsummary.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ CTxSummary::TxEntryBase::TxEntryBase(const char* _key, const LogLevel _logLevel,
else
name = fullname.str();
}

// The expectation for JSON-formatted output is for numeric values to be presented as numbers.
// Appending suffix text to unquoted JSON numbers invalidates the data, which suggests suffizes
// should be embedded in names. Record when a separate suffix will be ignored.
if (!suffix.isEmpty())
IWARNLOG("TxSummary entry with name '%s' and suffix '%s'; suffix is ignored", _key, _suffix);
}

bool CTxSummary::TxEntryBase::shouldSerialize(const LogLevel requestedLevel, const unsigned int requestedGroup)
Expand Down

0 comments on commit 1024fa0

Please sign in to comment.