[Possible] Bug fix: Using instance level and mtx wait #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling only static member methods will not take into account the class instance defined log level, which will lead to times where specific log levels via
log.info, log.error, log.warning
should not be logged, but they do.We define the log level for the created instance
LOGGING::Logging log{ESP_LOG_WARN};
but this logic is currently unused.Code before:
If we initialize two logging instances:
By calling the log2 instance it should return
ESP_ERR_INVALID_STATE
.Before commit: It logs, because of
default_level < level
, where default_level is a static variable, that isESP_LOG_INFO
.After commit:
ESP_ERR_INVALID_STATE
since we now use theinstance_level < level
.