Add option to expire

[asupian]

No description provided.

[colestrode]

Thanks @asupian :) I think this is a good contribution

I noticed a few things that could use some cleaning up.

It looks like you are missing a closing brace for your if. Make sure to run npm test, that will catch your linting errors and any failing tests (we can't merge anything in until npm test runs clean).

If object.expire is not a parseable number, this will pass NaN to the redis client. I'm thinking it would be good to test that expire is a number in the if clause, something like

if (object.expire && !isNaN(parseInt(object.expire))) {
  client.EXPIRE(object.id, parseInt(object.expire))
}

Also would you mind adding a few tests that ensure thatclient.EXPIRE is set correctly and that bad values are handled correctly.

Thanks again!

[asupian]

Thanks for the note - apologies for the haste in submitting the pull request!

[asupian]

@colestrode feel free to review and merge this pull request!

[colestrode]

This should be a double pipe operator for logical OR: ||

[colestrode]

Sorry for the delay on getting back to you! I thought I had submitted the last comment, but got thwarted by the new Github review UI. I finally submitted that today.

If you're still interested in this feature, would you mind adding some tests to cover setting an expiration successfully and handling any errors that may occur (non-number, non-integer, and 0 are cases that come to mind)? Thanks and sorry again for the wait.

[asupian]

Sure, I'll add that shortly