Initial Lan Mode Support #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put the lan client behind an experimentalLanClient configuration setting
|
Thanks for the contribution! As the LAN client is hidden behind a flag in configuration I think it should be safe to merge and release for the general public to test. Merging now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #41 .
This PR adds initial support for Lan mode, for devices which identify themselves as "plug". While there are references and code to support "strip" type devices, this is not currently working. I think this is something to do with the way that devices with multiple channels are currently handled (this is going to need a bit of refactoring to sort out I think).
This only supports getting and setting the power state for a device, and has been tested against an S26 plug.
This is currently hidden behind an additional configuration setting. To enable support for the lan client the following needs added to the platform configuration.
"experimentalLanClient": true