Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI to Compare and Apply Configs, Base Datasource Feature Additions #92

Draft
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

jaybythebay
Copy link
Contributor

@jaybythebay jaybythebay commented Jun 2, 2024

Overview

Adds functionality for updating datasources from config files. This will allow us to have less custom code in an AIrflow DAG (or any DAG) and use the cli to update changes based on a config

Changes

Changed

  • Moved column_init to it's own function

New

Open Questions

  • Will color styling in printing make re-using these functions in something like Airflow easy?
  • Why does column_init make list columns work even though I don't see the column tag added

Testing

Remove empty folders

Before

image

Cli Command

tableau_utilities --location local --file_path '/Users/jayrosenthal/code/tableau-utilities/development_test_files/has_empty_folder.tdsx' datasource --clean_folders

After

image

Mock tests passed

➜  pytest tests/test_datasource_remove_empty_folders.py -p no:warnings
=========================================================================================== test session starts ===========================================================================================
platform darwin -- Python 3.12.1, pytest-8.2.1, pluggy-1.5.0
rootdir: /Users/jayrosenthal/code/tableau-utilities
plugins: anyio-4.2.0
collected 3 items                                                                                                                                                                                         

tableau_utilities/test_tableau_file_objects.py ...                                                                                                                                                  [100%]

============================================================================================ 3 passed in 0.58s ============================================================================================
➜

@jaybythebay jaybythebay marked this pull request as draft June 2, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant