Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start of layout class #86

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jaybythebay
Copy link
Contributor

@jaybythebay jaybythebay commented May 25, 2024

Overview

By default a Tableau data extract is set to "Group By Datasource Table." When using the cli we can add a folder but then it's still not visible when you open the datasource in Tableau. This adds a show folders setting to enforce columns to make the display show folders.
image

   <layout _.fcp.SchemaViewerObjectModel.false...dim-percentage='0.5' _.fcp.SchemaViewerObjectModel.false...measure-percentage='0.4' dim-ordering='ordinal' measure-ordering='ordinal' show-structure='false' />

Changes

  • Add a Layout class
  • Set show-structure='true'

Testing

in progress

@jaybythebay jaybythebay marked this pull request as draft May 25, 2024 12:29
Add class to alter the layout settings and add showing folders to enforce columns
@@ -255,6 +262,11 @@ def enforce_column(self, column, folder_name=None, remote_name=None):
elif not folder:
self.folders_common.folder.add(tfo.Folder(name=folder_name, folder_item=[folder_item]))

# Set display to show folders
self.layout.update(show_structure='true')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinGrilli This code seems to be working except I'm getting stuck on altering the layout tags. Can you tell me how to apply this change?

@jaybythebay
Copy link
Contributor Author

@JustinGrilli I'm unsure of these things with this PR:

  1. How to apply the changes with layout
  2. If it matters that the layout tag has false... instead of true...
  3. How to deal with the dim-percentage and measure-percentage attributes since they look different than the other elements manipulated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant