Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.13 - Layout, Group By Folder #86

Closed
wants to merge 7 commits into from

Conversation

jaybythebay
Copy link
Contributor

@jaybythebay jaybythebay commented May 25, 2024

Overview

By default a Tableau data extract is set to "Group By Datasource Table." When using the cli we can add a folder but then it's still not visible when you open the datasource in Tableau. This adds a show folders setting to enforce columns to make the display show folders.
image

   <layout _.fcp.SchemaViewerObjectModel.false...dim-percentage='0.5' _.fcp.SchemaViewerObjectModel.false...measure-percentage='0.4' dim-ordering='ordinal' measure-ordering='ordinal' show-structure='false' />

Changes

  • Add a Layout class
  • Set show-structure='false' when running enforce column

Testing

Before

image

After

image image

@jaybythebay jaybythebay marked this pull request as draft May 25, 2024 12:29
Add class to alter the layout settings and add showing folders to enforce columns
@jaybythebay
Copy link
Contributor Author

@JustinGrilli I'm unsure of these things with this PR:

  1. How to apply the changes with layout
  2. If it matters that the layout tag has false... instead of true...
  3. How to deal with the dim-percentage and measure-percentage attributes since they look different than the other elements manipulated

@jaybythebay jaybythebay marked this pull request as ready for review January 14, 2025 22:56
@jaybythebay
Copy link
Contributor Author

@JustinGrilli thanks for the help and guidance on this. This PR is working now. I'm leaving this as a separate PR for ease of review but this has a version of 2.2.13. So it can be included in that release.

@jaybythebay jaybythebay changed the title start of layout class Release 2.2.13: Layout, Group By Folder Jan 14, 2025
@jaybythebay jaybythebay changed the title Release 2.2.13: Layout, Group By Folder Release 2.2.13 - Layout, Group By Folder Jan 14, 2025
Copy link
Collaborator

@JustinGrilli JustinGrilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can you branch this off your other PR and merge it into there? That way we can ensure there are no conflicts before we merge both. 🙏

@jaybythebay
Copy link
Contributor Author

Closing this PR and merged this into the other branch for a single release PR.

@jaybythebay jaybythebay deleted the show-folders branch January 24, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants