w.i.p. daily limit counter

[mwoz123]

Issue: #667

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

• issue was opened to discuss proposed changes before starting implementation.
• during development, node version specified in package.json was used (ie using nvm).
• package versions and package-lock.json were not changed (npm install --no-save).
• app version number was not changed.
• all new code has tests to ensure against regressions.
• npm run lint reports no offenses.
• npm run test is error-free.
• README and CHANGELOG were updated accordingly.
• after PR is approved, all commits in it are squashed

Description of the Change

Help adapting lines:
https://github.com/hovancik/stretchly/pull/680/files#diff-0a3ec7d7c0484270905e25a072b4f0c8L74
apprecaited. I don't quite follow the logic here (L74-L102) :/

Daily limit counter - informs when it's time to stop working with computer

Verification Process

Other information

[codecov]

Codecov Report

Merging #680 into master will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   85.81%   86.18%   +0.36%     
==========================================
  Files          12       12              
  Lines         275      275              
==========================================
+ Hits          236      237       +1     
+ Misses         39       38       -1     

Impacted Files	Coverage Δ
app/utils/defaultSettings.js	100.00% <ø> (ø)
app/utils/untilMorning.js	100.00% <0.00%> (+4.76%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979a862...176bbfd. Read the comment docs.

[hovancik]

Hey @mwoz123 , we should first talk about feature before writing any code.

How do you imagine this should work?

[mwoz123]

Daily limit should have same/similar rule set as micro- and break.

Popup should appear after (default) e.g. 6 or 8h, and can be postpone or skipped.
Daily limit should have no "break duration" time.

Once breaks are paused, or rested - daily limit counter should also be paused/rested.
(I havne't check how "natural break" works but it would be good to delay daily limit after certain period of inactivity or even reset after long enough inactivity - but I think this should be next PR)

I created "skip to daily limit" - it doesnt' have much logic sense - it's temp function to simplify development, so don't be confused by that;)
Should be removed once everything is working fine.

Did I miss something?

[hovancik]

To be honest, I am not sure about this. I don't like the idea of adding features that other apps have, Workrave in this case. I would prefer Stretchly to be different.

Stretchly is break time reminder app. This feature looks like a timer to finish ones shift. There are hundreds of apps for counting time or timers. I would prefer to keep Stretchly simple, as every extra features make it harder to maintain and to add core features. This feature seems to be as it should be separate application.

[mwoz123]

I would prefer to keep Stretchly simple, as every extra features make it harder to maintain and to add core features.

(From developer point of view) I totally agree.
Especially when there probably would be a need to change breakPlanner.js lines 74-102 which already has complicated logic.

There are hundreds of apps for counting time or timers

Here I disagree.
Why someone should have 2 counting down time apps and displaying notification once time is up running in same time on same system?

How about creating array that will contain number of break timers (and their configuraiton) and if someone will want to have 10 time's up reminders (instead 2 - but I belive most users will want at most 3) can be easily set in configuration. If some wants 1 will change the configuration to 1, and so on..
How about that?

Stretchly is break time reminder app.

Btw I was wondering why it's not marked with "RSI" or "prevent "Repetitive strain injury" (RSI) in tags or description.
It might be easier to find this app;)
and wanted to propose it to you;)

Anyway is there a chance such feature will be accepted? I thought so from your anser #667 (comment)

[hovancik]

I will need to think more. Because much more people request that I will add "custom working times", which goes in similar direction but it would be then close to impossible to have both. Maybe a combination where people can define working hours and be notified at the end?

[mwoz123]

"moving" conversation to #667

[mwoz123]

@hovancik I replied in issue :

• FR: Daily limit clock ? #667 (comment)
• FR: Daily limit clock ? #667 (comment)

What you think?