feat: add doorway link to footer #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for housing-sanjoseca-gov ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for hba-public-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ludtkemorgan
approved these changes
Jun 23, 2023
ludtkemorgan
added a commit
that referenced
this pull request
Jun 26, 2023
This reverts commit e56dc6f.
ludtkemorgan
added a commit
that referenced
this pull request
Jun 27, 2023
* fix: use proper class for sidebar headers (bloom-housing#3488) * fix: use proper class for sidebar headers * fix: modify margin for missing headings * fix: cypress coverage (bloom-housing#3469) * fix: cypress coverage * fix: corrected common application check * fix: reset tests * fix: testing reset * fix: validate url field in building section criteria (bloom-housing#3460) * fix: validate url field in building section criteria * fix: use url type field with https error for open house * fix: use different error messages for errors in url type fields * chore: upgrade uic * fix: validate url in settings tab * fix: add https placeholder for url fields * chore: update ui-components * fix: do a cache purge on listings cron job (bloom-housing#3512) * fix: do a cache purge on listings cron job * fix: test fixes * Revert "feat: add doorway link to footer (#624)" This reverts commit e56dc6f. --------- Co-authored-by: Krzysztof Zięcina <[email protected]> Co-authored-by: ColinBuyck <[email protected]>
ludtkemorgan
added a commit
that referenced
this pull request
Jun 27, 2023
This reverts commit 047c300.
ludtkemorgan
added a commit
that referenced
this pull request
Jun 29, 2023
* Revert "Revert "feat: add doorway link to footer (#624)"" This reverts commit 047c300. * fix: remove file name column in photos table (bloom-housing#3521) * fix: remove fileName column in photo table * fix: remove fileName column in details photo table * test: upgrade test to not use file name --------- Co-authored-by: Krzysztof Zięcina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #618
Description
Adds link in footer to doorway. Used approach with doorway link from #621 (so here is required locally
DOORWAY_URL=https://dev.doorway.housingbayarea.orgenv variable)How Can This Be Tested/Reviewed?
For Alameda / San Jose and San Mateo check footer if it starts with doorway link. Test every language (Filipino only available in Alameda)
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.