fix: remove application due date question (#613)

housingbayarea · May 9, 2023 · f054a4e · f054a4e
1 parent 0c99878
commit f054a4e
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 50 deletions.
diff --git a/sites/partners/cypress/integration/03-listing.spec.ts b/sites/partners/cypress/integration/03-listing.spec.ts
@@ -83,7 +83,6 @@ describe("Listing Management Tests", () => {
       cy.getByID("specialNotes").type(listing["specialNotes"])
       cy.get(".text-right > .button").contains("Application Process").click()
       cy.get("#reviewOrderFCFS").check()
-      cy.get("#dueDateQuestionNo").check()
       cy.get("#waitlistOpenNo").check()
       cy.getByID("leasingAgentName").type(listing["leasingAgentName"])
       cy.getByID("leasingAgentEmail").type(listing["leasingAgentEmail"])
@@ -197,7 +196,6 @@ describe("Listing Management Tests", () => {
       cy.get("#programRules").contains(listing["programRules"])
       cy.get("#specialNotes").contains(listing["specialNotes"])
       cy.get("#reviewOrderQuestion").contains("First come first serve")
-      cy.get("#dueDateQuestion").contains("No")
       cy.get("#leasingAgentName").contains(listing["leasingAgentName"])
       cy.get("#leasingAgentEmail").contains(listing["leasingAgentEmail"].toLowerCase())
       cy.get("#leasingAgentPhone").contains("(520) 245-8811")

diff --git a/...artners/src/components/listings/PaperListingDetails/sections/DetailRankingsAndResults.tsx b/...artners/src/components/listings/PaperListingDetails/sections/DetailRankingsAndResults.tsx
@@ -55,13 +55,6 @@ const DetailRankingsAndResults = () => {
           </GridSection>
         </>
       )}
-      {getReviewOrderType() === ListingReviewOrder.firstComeFirstServe && (
-        <GridSection columns={2}>
-          <ViewItem id="dueDateQuestion" label={t("listings.dueDateQuestion")}>
-            {listing.applicationDueDate ? t("t.yes") : t("t.no")}
-          </ViewItem>
-        </GridSection>
-      )}
       {listing.reviewOrderType === ListingReviewOrder.waitlist && (
         <>
           <GridSection columns={2}>

diff --git a/sites/partners/src/components/listings/PaperListingForm/sections/ApplicationDates.tsx b/sites/partners/src/components/listings/PaperListingForm/sections/ApplicationDates.tsx
@@ -1,6 +1,5 @@
 import React, { useState, useMemo } from "react"
-import { useWatch, useFormContext } from "react-hook-form"
-import { YesNoAnswer } from "../../../../lib/helpers"
+import { useFormContext } from "react-hook-form"
 import { getDetailFieldDate, getDetailFieldTime } from "../../PaperListingDetails/sections/helpers"
 import dayjs from "dayjs"
 
@@ -85,12 +84,7 @@ const ApplicationDates = ({
   const formMethods = useFormContext()
 
   // eslint-disable-next-line @typescript-eslint/unbound-method
-  const { register, watch, control } = formMethods
-
-  const enableDueDate = useWatch({
-    control,
-    name: "dueDateQuestion",
-  })
+  const { register, watch } = formMethods
 
   const [drawerOpenHouse, setDrawerOpenHouse] = useState<TempEvent | boolean>(false)
   const [modalDeleteOpenHouse, setModalDeleteOpenHouse] = useState<TempEvent | null>(null)
@@ -131,7 +125,6 @@ const ApplicationDates = ({
             register={register}
             watch={watch}
             note={t("listings.whenApplicationsClose")}
-            disabled={enableDueDate === YesNoAnswer.No}
             defaultDate={{
               month: listing?.applicationDueDate
                 ? dayjs(new Date(listing?.applicationDueDate)).format("MM")
@@ -150,22 +143,15 @@ const ApplicationDates = ({
             id={"applicationDueTimeField"}
             register={register}
             watch={watch}
-            disabled={enableDueDate === YesNoAnswer.No}
             defaultValues={{
               hours: listing?.applicationDueDate
                 ? dayjs(new Date(listing?.applicationDueDate)).format("hh")
-                : enableDueDate === YesNoAnswer.No
-                ? null
                 : "05",
               minutes: listing?.applicationDueDate
                 ? dayjs(new Date(listing?.applicationDueDate)).format("mm")
-                : enableDueDate === YesNoAnswer.No
-                ? null
                 : "00",
               seconds: listing?.applicationDueDate
                 ? dayjs(new Date(listing?.applicationDueDate)).format("ss")
-                : enableDueDate === YesNoAnswer.No
-                ? null
                 : "00",
               period: listing?.applicationDueDate
                 ? new Date(listing?.applicationDueDate).getHours() >= 12

diff --git a/sites/partners/src/components/listings/PaperListingForm/sections/RankingsAndResults.tsx b/sites/partners/src/components/listings/PaperListingForm/sections/RankingsAndResults.tsx
@@ -99,30 +99,6 @@ const RankingsAndResults = ({ listing }: RankingsAndResultsProps) => {
             </GridCell>
           </GridSection>
         )}
-        {reviewOrder === "reviewOrderFCFS" && (
-          <GridSection columns={2} className={"flex items-center"}>
-            <GridCell>
-              <p className="field-label m-4 ml-0">{t("listings.dueDateQuestion")}</p>
-              <FieldGroup
-                name="dueDateQuestion"
-                type="radio"
-                register={register}
-                fields={[
-                  {
-                    ...yesNoRadioOptions[0],
-                    id: "dueDateQuestionYes",
-                    defaultChecked: listing && listing.applicationDueDate !== null,
-                  },
-                  {
-                    ...yesNoRadioOptions[1],
-                    id: "dueDateQuestionNo",
-                    defaultChecked: listing && !listing.applicationDueDate,
-                  },
-                ]}
-              />
-            </GridCell>
-          </GridSection>
-        )}
         {reviewOrder === "reviewOrderLottery" && (
           <>
             <GridSection columns={3}>

diff --git a/sites/partners/src/page_content/locale_overrides/general.json b/sites/partners/src/page_content/locale_overrides/general.json
@@ -167,7 +167,6 @@
   "listings.details.updatedDate": "Date Updated",
   "listings.developer": "Housing Developer",
   "listings.dropOffAddress": "Drop Off Address",
-  "listings.dueDateQuestion": "Is there an application due date?",
   "listings.editPreferences": "Edit Preferences",
   "listings.events.deleteConf": "Do you really want to delete this event?",
   "listings.events.deleteThisEvent": "Delete this event",