Add coverage for focus and value preservation during morph #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idiomorph will preserve focus, but discard content. Version [0.0.9][] introduces the `ignoredActiveValue:` option to preserve the value for the element with focus. Since the currently packaged build isn't caught up to that version, the `[data-turbo-permanent]` treatment enables a similar kind of behavior. This commit adds test coverage to ensure that focus preservation is global, and value preservation requires opt-in with `[data-turbo-permanent]`. [0.0.9]: https://github.com/bigskysoftware/idiomorph/tree/v0.0.9#options
|
@afcapel this should be easy to review, there aren't any implementation changes. |
afcapel
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idiomorph will preserve focus, but discard content. Version 0.0.9 introduces the
ignoredActiveValue:option to preserve the value for the element with focus. Since the currently packaged build isn't caught up to that version, the[data-turbo-permanent]treatment enables a similar kind of behavior.This commit adds test coverage to ensure that focus preservation is global, and value preservation requires opt-in with
[data-turbo-permanent].