-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add turbo stream morph actions to broadcasts #583
add turbo stream morph actions to broadcasts #583
Conversation
365feee
to
41d8b84
Compare
266fa01
to
36cba12
Compare
738f182
to
da14d4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @omarluq. One minor comment. Thanks!
da14d4e
to
2b754d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @omarluq!
@jorgemanrubia when could we expect to get this in a release? |
I just got tripped up trying to use this, as I thought the morph action was available. Is there a plan to get this released? Thanks! |
Yeah @paulsturgess, just tripped over this myself. Looks like the docs PR was reverted, and @jorgemanrubia refers to a different API that is described in this open PR, so I assume this was undone and nobody left a link in the original issue or this PR. Would love if someone could let us know what the plan is! |
@searls @paulsturgess Sorry about the confusion here! I reverted the documentation change for this one since we hadn't done a release containing it, so people were confused when they saw it in the docs, but it didn't work. Also, @seanpdoyle reworked the API to support this here hotwired/turbo#1240. What we will do this week is to release a new version of Sorry about the confusion 🙏 . |
Thanks for this! Excited to remove my home-rolled implementation and shed the direct idiomorph dependency. |
This PR adds support for the Turbo Stream Morph action
Turbo::StreamsChannel.broadcast_morph_to
and it's variants, complementing the Morph action PR hotwired/turbo#1185