Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when snapshot cache is cleared #185

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix when snapshot cache is cleared #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions Source/Session/Session.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,15 @@ extension Session: VisitableDelegate {
public func visitableViewWillAppear(_ visitable: Visitable) {
guard let topmostVisit = self.topmostVisit, let currentVisit = self.currentVisit else { return }

if visitable === topmostVisit.visitable && visitable.visitableViewController.isMovingToParent {
if isSnapshotCacheStale {
clearSnapshotCache()
isSnapshotCacheStale = false
}

if isShowingStaleContent {
reload()
isShowingStaleContent = false
} else if visitable === topmostVisit.visitable && visitable.visitableViewController.isMovingToParent {
// Back swipe gesture canceled
if topmostVisit.state == .completed {
currentVisit.cancel()
Expand All @@ -242,12 +250,6 @@ extension Session: VisitableDelegate {
} else if visitable !== topmostVisit.visitable {
// Navigating backward
visit(visitable, action: .restore)
} else if isShowingStaleContent {
reload()
isShowingStaleContent = false
} else if isSnapshotCacheStale {
clearSnapshotCache()
isSnapshotCacheStale = false
}
}

Expand Down