Fix issue where snapshot cache doesn't get cleared

hotwired · Feb 26, 2024 · 0dbf9d9 · 0dbf9d9
1 parent cbb7356
commit 0dbf9d9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Source/Session/Session.swift b/Source/Session/Session.swift
@@ -10,7 +10,9 @@ public class Session: NSObject {
 
     public let webView: WKWebView
     public var pathConfiguration: PathConfiguration?
-
+
+    var needsCacheClearing = false
+
     private lazy var bridge = WebViewBridge(webView: webView)
     private var initialized = false
     private var refreshing = false
@@ -215,6 +217,11 @@ extension Session: VisitableDelegate {
     public func visitableViewWillAppear(_ visitable: Visitable) {
         guard let topmostVisit = self.topmostVisit, let currentVisit = self.currentVisit else { return }
 
+        if needsCacheClearing {
+            clearSnapshotCache()
+            needsCacheClearing = false
+        }
+
         if visitable === topmostVisit.visitable && visitable.visitableViewController.isMovingToParent {
             // Back swipe gesture canceled
             if topmostVisit.state == .completed {

diff --git a/Source/Turbo Navigator/TurboNavigator.swift b/Source/Turbo Navigator/TurboNavigator.swift
@@ -143,7 +143,7 @@ extension TurboNavigator: SessionDelegate {
 
     public func sessionDidFinishFormSubmission(_ session: Session) {
         if session == modalSession {
-            self.session.clearSnapshotCache()
+            self.session.needsCacheClearing = true
         }
         if let url = session.topmostVisitable?.visitableURL {
             delegate.formSubmissionDidFinish(at: url)