Don't choke when controller is not present in the request #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
force-pushed
the
redirected-error
branch
from
ac78a9d to
8bb1de1
Compare
Co-authored-by: Bijan Rahnema <[email protected]>
jorgemanrubia
force-pushed
the
redirected-error
branch
from
e9b5432 to
b567e12
Compare
jorgemanrubia
commented
Dec 26, 2024
| require "application_system_test_case" | ||
|
|
||
| class MiddlewareTest < ActionDispatch::IntegrationTest | ||
| test "error" do |
There was a problem hiding this comment.
test renamed in 7ded7ac
|
Thx for jumping in so quickly Jorge. I've been to a Christmas dinner and couldn't respond so till now. Your check if interceptable method in the middleware makes a lot of sense and keeps the code simpler. It's a good practice to check at the boundaries 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks @gobijan for reporting and troubleshooting 🙏. Added as coauthor.
Close #54
Fix #53