Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Rails dependency to >= 7.0.0 #42

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

cbmike
Copy link
Contributor

@cbmike cbmike commented Dec 23, 2024

Works fine with Rails 7.1.3.

@cbmike cbmike mentioned this pull request Dec 23, 2024
@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
end

spec.add_dependency "rails", ">= 8.0.0"
spec.add_dependency "rails", ">= 7.1.3"
Copy link
Member

@jorgemanrubia jorgemanrubia Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make it 7.0.0? I don't think there is any difference between 7.1 and 7.0 regarding supporting this gem. Thanks 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

@cbmike cbmike changed the title Relax Rails dependency to >= 7.1.3 Relax Rails dependency to >= 7.0.0 Dec 23, 2024
Copy link
Member

@jorgemanrubia jorgemanrubia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks @cbmike 🙏

@jorgemanrubia jorgemanrubia merged commit a5ac411 into hotwired:main Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants