New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update refresh with last visitable #22

Merged

jayohms merged 2 commits into main from fix-refresh-behavior

Sep 20, 2024

Member

olivaresf commented Sep 19, 2024 •

edited

Loading

Turbo-iOS PR: hotwired/turbo-ios#220

While testing, I found that when a visit with a refresh presentation is proposed, TurboNavigatorHierarchyController will correctly pop (or dismiss) and then ask the session to reload. However, the session does not know that the topmost visitable changed, so a reload will end up reloading the last successfully loaded visit – the visitable that was just popped (or dismissed).

Fernando Olivares added 2 commits

September 19, 2024 11:23


          Update refresh with last visitable

da5249a


          Fix missing references

b3ba3cc

olivaresf requested a review from jayohms

September 19, 2024 22:50

jayohms approved these changes

View reviewed changes

jayohms merged commit e332e0e into main

1 check passed

jayohms deleted the fix-refresh-behavior branch

September 20, 2024 13:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet