Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: support to reject transfer order items(#903) #935

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ymaheshwari1
Copy link
Contributor

Related Issues

#903

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

After:

image

Contribution and Currently Important Rules Acceptance

Removed logic to display rejected items and the corresponding actions and services
Implemented support to reject entire order at once, only if any of the order items are not shipped
@ymaheshwari1
Copy link
Contributor Author

Made the improvements as per the discussion and comments added on the issue and updated the UI accordingly.

Updated UI:

If there is already a shipment associated with the order, rejection is not allowed on the order:

image

If no shipment is associated with order, order can be rejected:

image

If a rejection reason is selected on an item, all other items will be rejected with a default rejection reason:

image

For now, the default rejection reason is NO_VARIANCE_LOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant