Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Display Product Store ID instead of Store Name when Store Name is not present on the Find Facilities page. #343

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

priyanshee1604
Copy link
Contributor

@priyanshee1604 priyanshee1604 commented Jan 16, 2025

Related Issues

#323

Short Description and Why It's Useful

To improve user experience, we should display the product store ID in place of the store name if the name is not available.

Contribution and Currently Important Rules Acceptance

@priyanshee1604 priyanshee1604 changed the title Improved: Display Product Store ID instead of Store Name when Store Name is not present. Improved: Display Product Store ID instead of Store Name when Store Name is not present on the Find Facilities page.(#323) Jan 16, 2025
@priyanshee1604 priyanshee1604 changed the title Improved: Display Product Store ID instead of Store Name when Store Name is not present on the Find Facilities page.(#323) Improved: Display Product Store ID instead of Store Name when Store Name is not present on the Find Facilities page. Jan 16, 2025
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle this change on all the other places as well, like productStore popover, facility creation flow etc.

…ame is not present in productStore popover and in facility creation flow.
@ymaheshwari1 ymaheshwari1 merged commit 4cd83d8 into hotwax:main Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants