Improved: UI for lat-long card, UI for facility management, UI for Parking and Groups, button text #108
Conversation
src/views/FacilityDetails.vue
Outdated
| @@ -1113,9 +1115,7 @@ ion-card-header { | |||
| } | |||
|
|
|||
|
|
|||
| /*Height of segment is defined now since their are less list items. Will remove it later */ | |||
| .segments { | |||
There was a problem hiding this comment.
do we need to use a class or can we just select the element? @amansinghbais
There was a problem hiding this comment.
@dt2patel sir, div with segments class contains 3 child div inside it and some css is applied to those div tag with the help of 'segments' class as ".segments div". So if we don' t want to use segments class, we need to give some identifier(class) to the div inside for adding css on them.
src/views/FindGroups.vue
Outdated
| <h1>{{ group.facilityGroupName }}</h1> | ||
| <p>{{ group.facilityGroupId }}</p> | ||
| </ion-label> | ||
| <ion-button @click="openFacilityGroupActionsPopover($event, group)" fill="clear" color="medium"> |
src/views/FindGroups.vue
Outdated
| <ion-button color="medium" fill="clear" @click="openCreateFacilityGroupModal()"> | ||
| <ion-icon :icon="addOutline" slot="start"/> | ||
| {{ translate('Create group') }} | ||
| <main class="groups" v-if="groups.length"> |
There was a problem hiding this comment.
instead of using a class why not select the main element when it has cards?
There was a problem hiding this comment.
Yes we can, but then a doubt arises. This css should be moved to variable.css or has to be page specific.
There was a problem hiding this comment.
Yes it can be generalized in variables file
Related Issues
Closes #
Short Description and Why It's Useful
Improved:
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance