Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements in Partner Stats MapSwipe page #6601

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Enhancements in Partner Stats MapSwipe page #6601

merged 8 commits into from
Nov 13, 2024

Conversation

royallsilwallz
Copy link
Contributor

@royallsilwallz royallsilwallz commented Oct 22, 2024 •
edited
Loading

What type of PR is this?

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Refactor

Related Issue

Describe this PR

This PR solves the issues in Partner Stats MapSwipe page mentioned in the above ticket.

Key Changes

  • Show Map Swipe tab only when MapSwipe group ID present
  • Add name of the mapswipe group at the top of the page
  • Fix responsive issues for cards and charts in mobile view
  • Rename the text Ds to days
  • Rename Tasking manager partner's statistics page URL to /partners/<partner>/stats/
  • Implement new info design in all stats section

Screenshots

image

image

image

@royallsilwallz royallsilwallz force-pushed the enhancement/6599-partners-mapswipe-page-fixes branch from 591fa56 to 35d5b09 Compare October 22, 2024 08:48
@royallsilwallz royallsilwallz force-pushed the enhancement/6599-partners-mapswipe-page-fixes branch from 35d5b09 to cd34616 Compare October 25, 2024 05:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

emi420
emi420 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@emi420 emi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! nice that you've moved some styles to classes @royallsilwallz

@ramyaragupathy ramyaragupathy merged commit 1f35f84 into develop Nov 13, 2024
9 checks passed
@ramyaragupathy ramyaragupathy mentioned this pull request Nov 13, 2024
Closed
@ramyaragupathy
Copy link
Member

@ramyaragupathy ramyaragupathy mentioned this pull request Nov 13, 2024
Closed
@ramyaragupathy
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emi420 emi420 emi420 approved these changes

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional fixes on partner's mapswipe page
3 participants
@royallsilwallz @ramyaragupathy @emi420