Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #6165 by removing incorrect and conflicting instruction #6569

Conversation

erictheise
Copy link
Contributor

Removes incorrect and conflicting instruction about not using scheme on "next two variables". Second example does indeed include scheme and first example produces an incorrect link without scheme included.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Example: Fixes #6165

Describe this PR

See above.

Screenshots

Please provide screenshots of the change.

Review Guide

Notes for the reviewer. Probably look at your own variables in production. Barring that, set up a server using these instructions and check the website link in the upper right header; the domain name will appear as a path on the base server domain not as its own domain.

Checklist before requesting a review

…on about not using scheme on "next two variables". Second example does indeed include scheme and first example produces an incorrect link without scheme included.
Copy link

sonarcloud bot commented Sep 20, 2024

Copy link
Collaborator

@mahesh-naxa mahesh-naxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this.

@ramyaragupathy ramyaragupathy merged commit 1867b92 into hotosm:develop Oct 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TM_ORG_URL should include http:// or https://
4 participants