Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iD editor upgrade to v2.30.2 #6551

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

emi420
Copy link
Collaborator

@emi420 emi420 commented Sep 3, 2024

What type of PR is this?

  • ❓ Other (dependency upgrade)

Related Issue

Fixes #5780

Describe this PR

A new version (2.30.2) of the iD Editor was published as a NPM package on hotosm/id

This PR upgrades the package and also adds a configuration line for Webpack to ignore and not parse the iD.min.js file, as it was raising some warnings:

Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
Critical dependency: the request of a dependency is an expression

Search for the keywords to learn more about each warning. 
To ignore, add // eslint-disable-next-line to the line before.

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 14:40-47
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 17:37-44
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./node_modules/@hotosm/id/dist/iD.min.js 40022:67-76
Critical dependency: the request of a dependency is an expression

It should be ok as this is a packed and minified file.

Copy static files and imagery patch

I've also divided the commands in package.json for copying static files for both iD and Rapid and removed the patch for the iD imagery as isn't being used anymore.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file scope: frontend labels Sep 3, 2024
@emi420 emi420 reopened this Sep 16, 2024
@github-actions github-actions bot added dependencies Pull requests that update a dependency file scope: frontend labels Sep 16, 2024
Copy link

sonarcloud bot commented Sep 16, 2024

1 similar comment
Copy link

sonarcloud bot commented Sep 16, 2024

@royallsilwallz
Copy link
Contributor

hey @emi420 , we have another issue related to iD upgrade. When I toggle the editor to RapiD and again back to iD, an error occurs. Below is the screenshot -

image

Other findings
I have also tried it on different branches (develop). It still shows the same error.
So, it is not specific to this (upgrade/iD-editor-2.30.2) branch.
Older version (v2.29.0) did not have this error.

Steps to reproduce

  • Go to any project
  • Map a task
  • Change the editor to RapiD
  • Again change it back to iD
  • See the error

cc - @ramyaragupathy @manjitapandey

@ramyaragupathy ramyaragupathy merged commit cae8fb4 into develop Sep 19, 2024
10 checks passed
@emi420 emi420 deleted the upgrade/iD-editor-2.30.2 branch September 19, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iD editor version upgrade
4 participants