Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project summary table view #6504

Merged
merged 58 commits into from
Sep 10, 2024
Merged

Project summary table view #6504

merged 58 commits into from
Sep 10, 2024
+22,688 −15,505

Conversation

bshankar
Copy link
Collaborator

@bshankar bshankar commented Jul 17, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature

Related Issue

Example: Fixes #6500

Describe this PR

  1. Adds a new table view for projects to go alongside the existing grid view
  2. Filter projects by by partner ID and time range.
  3. Sort projects by due date, percentage mapped and validated.
  4. Download list of projects as a CSV file.

Screenshots

screenshot_from_2024-08-19_17-22-39_720
screenshot_from_2024-08-19_17-23-41_720
screenshot_from_2024-08-19_17-24-35_720
screenshot_from_2024-08-19_17-23-03_720

@bshankar bshankar mentioned this pull request Jul 17, 2024
Closed
1 task
@bshankar bshankar force-pushed the feature/6500-project-summary-table-view branch 5 times, most recently from 06f2828 to 6c9b9c4 Compare July 24, 2024 03:53
@bshankar bshankar force-pushed the feature/6500-project-summary-table-view branch 9 times, most recently from 05e8ec4 to caef72f Compare July 31, 2024 02:18
@bshankar bshankar force-pushed the feature/6500-project-summary-table-view branch from caef72f to c6aa251 Compare August 6, 2024 04:50
@bshankar bshankar force-pushed the feature/6500-project-summary-table-view branch from 6b10d3e to 29fcc5b Compare August 13, 2024 11:52
@github-actions github-actions bot added dependencies Pull requests that update a dependency file scope: frontend and removed scope: infrastructure scope: frontend labels Aug 13, 2024
@bshankar bshankar force-pushed the feature/6500-project-summary-table-view branch 3 times, most recently from db96a47 to 96aa4dc Compare August 19, 2024 11:35
@bshankar bshankar marked this pull request as ready for review August 19, 2024 11:38
@bshankar bshankar changed the title [WIP] Project summary table view Project summary table view Aug 19, 2024
VinayakRugvedi and others added 26 commits September 6, 2024 19:12
@VinayakRugvedi @bshankar
Update state handling and integrate with query params
e91e5ad
@VinayakRugvedi @bshankar
Handle overflow for explore projects table view
d2e78b4
@VinayakRugvedi @bshankar
feat: implement download CSV for project details
1475752
@VinayakRugvedi @bshankar
feat: update download CSV link
cd212b3
@VinayakRugvedi @bshankar
feat: handle empty state of projects table
76f6b30
@VinayakRugvedi @bshankar
Update behaviour of clear filters
2fa85ad
@VinayakRugvedi @bshankar
Link name to details, mappers to contributors, and fix due date column
5f0aa05
@VinayakRugvedi @bshankar
feat: add due soon, most mapped, and most validated options to sort by
4bdf201
@VinayakRugvedi @bshankar
fix: dont set omitMapResults when downloadAsCSV is true
1f531c4
@VinayakRugvedi @bshankar
feat: handle empty state of projects table
de9ec02
@bshankar
Fix: Cannot set omitMapResults when downloadAsCSV is true
c2e69e0 
Use df.drop instead of del with the pandas dataframe
@bshankar
Feat: Add organisation name to CSV
06b0d66
@bshankar
Fix: Rename CSV column total_area -> totalAreaSquareKilometers
900d43b
@bshankar
Chore: Add a comment to clarify total area computation
28ce653
@VinayakRugvedi @bshankar
Show tooltip content only if present
6fd975a
@VinayakRugvedi @bshankar
Add custom tooltip to progress, set omitMapResults to undefined for C…
5d0e16e 
…SV download, and remove table stripe
@VinayakRugvedi @bshankar
Handle empty data column, update basic styling of table, and add titl…
cc816d2 
…e attribute
@VinayakRugvedi @bshankar
refactor: use conditional operator, simplify expression
9f2bf02
@VinayakRugvedi @bshankar
fix: change medium to moderate, ensure tooltip is not masked by progr…
89054f1 
…ess bar
@VinayakRugvedi @bshankar
Set fill to currentColor on DownloadIcon
5f015ed
@VinayakRugvedi @bshankar
feat: replace anchor tag with thorough state and api integration for …
04952a7 
…download as CSV
@VinayakRugvedi @bshankar
Set minimum threshold width of progress bar
5a57a35
@VinayakRugvedi @bshankar
fix: remap query params to API spec while downloading as CSV
51c8c3b
@bshankar
Fix: percent_mapped and validated calculation in table view
2571921
@bshankar
Fix: CSV: Remove empty partnerNames column for non admins
28b61f3
@bshankar
Fix: CSV: Round total area in Sqkm to 3 decimal places
6bf7f2b
@bshankar bshankar force-pushed the feature/6500-project-summary-table-view branch from 1da9ad5 to 6bf7f2b Compare September 6, 2024 13:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

emi420
emi420 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@emi420 emi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're ready to go with this!

@ramyaragupathy ramyaragupathy merged commit 249ae84 into hotosm:develop Sep 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royallsilwallz royallsilwallz royallsilwallz approved these changes

@emi420 emi420 emi420 approved these changes

@prabinoid prabinoid Awaiting requested review from prabinoid

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file scope: backend scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Summary Table View
5 participants
@bshankar @emi420 @VinayakRugvedi @royallsilwallz @ramyaragupathy