fix: list pods by resourceTree instread of labelSelectors #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit c0d4ace and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (60% is the threshold). This pull request will bring the total coverage in the repository to 65.8% (0.0% change). View more on Code Climate. |
kilosonc
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Using tag selectors to query a list of pods is not entirely reliable, ArgoCD consider that and utilizes the owner reference to build a resource tree, Horizon should rely on it too.
I have:
make build && make lintto ensure this PR is ready for review.How has this code been tested
I have tested this code in local and dev environment, pod list remains the same as before this fix.
Special notes for your reviewer