Feat: support for pipelinerun checks #193

xuzhu-591 · 2023-09-12T11:35:00Z

Description of your changes

feat: add check api
feat: support for pipelinerun checks

Fixes #

I have:

Read and followed Horizon's contribution process.
Run make build && make lint to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

codeclimate · 2023-09-18T11:37:22Z

pkg/pr/dao/pipelinerun.go

 }

-func (d *dao) GetFirstCanRollbackPipelinerun(ctx context.Context, clusterID uint) (*models.Pipelinerun, error) {
+func (d *pipelinerunDAO) GetFirstCanRollbackPipelinerun(ctx context.Context,


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2023-09-18T11:37:23Z

pkg/pr/service/service.go

+	}
+	return pipelineBasics, nil
+}
+func (s *Service) GetCheckByResource(ctx context.Context, resourceID uint,


Method Service.GetCheckByResource has 5 return statements (exceeds 4 allowed).

codeclimate · 2023-09-18T11:37:23Z

core/http/api/v2/pipelinerun/apis.go

+	})
+}
+
+func (a *API) CreatePrMessage(c *gin.Context) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-18T11:37:23Z

core/controller/cluster/controller_basic_v2.go

+	return c.prSvc.OfPipelineBasic(ctx, pipelineRun, firstCanRollbackPipelinerun)
+}
+
+func (c *controller) createPipelineRun(ctx context.Context, clusterID uint,


Method controller.createPipelineRun has 109 lines of code (exceeds 50 allowed). Consider refactoring.

codeclimate · 2023-09-18T11:37:23Z

core/controller/cluster/controller_basic_v2.go

+			} else if r.Git.Tag != "" {
+				gitRefType = codemodels.GitRefTypeTag
+				gitRef = r.Git.Tag
+			} else if r.Git.Branch != "" {


Avoid deeply nested control flow statements.

Signed-off-by: closetool <[email protected]>

Signed-off-by: kiloson <[email protected]>

Signed-off-by: xu.zhu <[email protected]>

codeclimate · 2023-09-19T06:46:45Z

pkg/pr/dao/check.go

+	return checkRuns, nil
+}
+
+func (d *checkDAO) CreateCheckRun(ctx context.Context, run *models.CheckRun) (*models.CheckRun, error) {


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2023-09-19T06:46:46Z

core/http/api/v2/pipelinerun/apis.go

+	response.SuccessWithData(c, checkRuns)
+}
+
+func (a *API) CreateCheckRun(c *gin.Context) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-19T06:46:46Z

core/controller/cluster/controller_basic_v2.go

@@ -659,3 +661,185 @@ func (c *controller) ToggleLikeStatus(ctx context.Context, clusterID uint, like
 	}
 	return nil
 }
+
+func (c *controller) CreatePipelineRun(ctx context.Context, clusterID uint,


Method controller.CreatePipelineRun has 5 return statements (exceeds 4 allowed).

codeclimate · 2023-09-19T06:46:46Z

core/controller/cluster/controller_basic_v2.go

+	return c.prSvc.OfPipelineBasic(ctx, pipelineRun, firstCanRollbackPipelinerun)
+}
+
+func (c *controller) createPipelineRun(ctx context.Context, clusterID uint,


Method controller.createPipelineRun has 13 return statements (exceeds 4 allowed).

codeclimate · 2023-09-19T06:46:47Z

core/controller/pipelinerun/controller.go

+	return c.execute(ctx, pr)
+}
+
+func (c *controller) execute(ctx context.Context, pr *prmodels.Pipelinerun) error {


Method controller.execute has 79 lines of code (exceeds 50 allowed). Consider refactoring.

Signed-off-by: xu.zhu <[email protected]>

codeclimate · 2023-09-19T08:23:51Z

pkg/pr/dao/pipelinerun.go

 }

-func (d *dao) Create(ctx context.Context, pipelinerun *models.Pipelinerun) (*models.Pipelinerun, error) {
+func (d *pipelinerunDAO) Create(ctx context.Context, pipelinerun *models.Pipelinerun) (*models.Pipelinerun, error) {


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2023-09-19T08:23:52Z

core/controller/cluster/controller_basic_v2.go

+	case prmodels.ActionBuildDeploy:
+		action = prmodels.ActionBuildDeploy
+
+		if r.Git != nil {


Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-19T08:23:52Z

pkg/pr/dao/check.go

+	"github.com/horizoncd/horizon/pkg/pr/models"
+)
+
+type CheckDAO interface {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-19T08:23:52Z

core/controller/pipelinerun/controller.go

+	return c.execute(ctx, pr)
+}
+
+func (c *controller) execute(ctx context.Context, pr *prmodels.Pipelinerun) error {


Method controller.execute has 12 return statements (exceeds 4 allowed).

codeclimate · 2023-09-19T08:23:52Z

core/controller/pipelinerun/controller.go

+	return c.updatePrStatus(ctx, Checkrun)
+}
+
+func (c *controller) updatePrStatus(ctx context.Context, checkrun *prmodels.CheckRun) error {


Method controller.updatePrStatus has 5 return statements (exceeds 4 allowed).

kilosonc

See comments below

core/controller/pipelinerun/controller.go

pkg/event/models/event.go

Signed-off-by: xu.zhu <[email protected]>

codeclimate · 2023-09-20T09:12:08Z

pkg/pr/manager/check.go

+// nolint
+//
+//go:generate mockgen -source=$GOFILE -destination=../../../mock/pkg/pipelinerun/manager/mock_check_manager.go
+type CheckManager interface {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-20T09:12:09Z

pkg/pr/dao/message.go

+	return &prMessageDAO{db: db}
+}
+
+func (d *prMessageDAO) Create(ctx context.Context, prMessage *models.PRMessage) (*models.PRMessage, error) {


Similar blocks of code found in 5 locations. Consider refactoring.

codeclimate · 2023-09-20T09:12:09Z

pkg/pr/dao/pipelinerun.go

@@ -142,7 +145,7 @@ func (d *dao) GetLatestByClusterIDAndActionAndStatus(ctx context.Context,
 	return &pipelinerun, nil
 }

-func (d *dao) GetLatestSuccessByClusterID(ctx context.Context, clusterID uint) (*models.Pipelinerun, error) {
+func (d *pipelinerunDAO) GetLatestSuccessByClusterID(ctx context.Context, clusterID uint) (*models.Pipelinerun, error) {


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2023-09-20T09:12:09Z

core/controller/pipelinerun/controller.go

+	return c.prMgr.PipelineRun.UpdateStatusByID(ctx, checkrun.PipelineRunID, prStatus)
+}
+
+func (c *controller) calculatePrSuccessStatus(ctx context.Context,


Method controller.calculatePrSuccessStatus has 6 return statements (exceeds 4 allowed).

pkg/pr/dao/pipelinerun.go

Signed-off-by: xu.zhu <[email protected]>

codeclimate · 2023-09-20T13:55:20Z

core/controller/pipelinerun/controller.go

+	return c.execute(ctx, pr)
+}
+
+func (c *controller) execute(ctx context.Context, pr *prmodels.Pipelinerun) error {


Method controller.execute has 83 lines of code (exceeds 50 allowed). Consider refactoring.

codeclimate · 2023-09-20T13:55:20Z

pkg/pr/dao/pipelinerun.go

@@ -73,7 +76,7 @@ func (d *dao) GetByID(ctx context.Context, pipelinerunID uint) (*models.Pipeline
 	return &pr, nil
 }

-func (d *dao) GetByCIEventID(ctx context.Context, ciEventID string) (*models.Pipelinerun, error) {
+func (d *pipelinerunDAO) GetByCIEventID(ctx context.Context, ciEventID string) (*models.Pipelinerun, error) {


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2023-09-20T13:55:20Z

core/http/api/v2/cluster/apis_basic.go

@@ -527,3 +528,35 @@ func (a *API) DeleteFavorite(c *gin.Context) {
 	}
 	response.Success(c)
 }
+
+func (a *API) CreatePipelineRun(c *gin.Context) {


Method API.CreatePipelineRun has 5 return statements (exceeds 4 allowed).

codeclimate · 2023-09-20T13:55:20Z

core/http/api/v2/pipelinerun/apis.go

+	f(uint(id))
+}
+
+func (a *API) withCheckrunID(c *gin.Context, f func(pipelineRunID uint)) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-20T13:55:20Z

pkg/pr/service/service.go

+	}
+	return pipelineBasics, nil
+}
+func (s *Service) GetCheckByResource(ctx context.Context, resourceID uint,


Method Service.GetCheckByResource has 52 lines of code (exceeds 50 allowed). Consider refactoring.

Signed-off-by: xu.zhu <[email protected]>

codeclimate · 2023-09-21T09:29:39Z

core/controller/cluster/controller_basic_v2.go

+	return c.prSvc.OfPipelineBasic(ctx, pipelineRun, firstCanRollbackPipelinerun)
+}
+
+func (c *controller) createPipelineRun(ctx context.Context, clusterID uint,


Method controller.createPipelineRun has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.

codeclimate · 2023-09-21T09:29:39Z

core/controller/pipelinerun/controller.go

+	})
+}
+
+func (c *controller) ListPRMessages(ctx context.Context,


Method controller.ListPRMessages has 57 lines of code (exceeds 50 allowed). Consider refactoring.

codeclimate · 2023-09-21T09:29:39Z

core/http/api/v2/pipelinerun/apis.go

+	})
+}
+
+func (a *API) withPipelinerunID(c *gin.Context, f func(pipelineRunID uint)) {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-21T09:29:39Z

pkg/pr/dao/pipelinerun.go

@@ -85,7 +88,7 @@ func (d *dao) GetByCIEventID(ctx context.Context, ciEventID string) (*models.Pip
 	return &pr, nil
 }

-func (d *dao) DeleteByClusterID(ctx context.Context, clusterID uint) error {
+func (d *pipelinerunDAO) DeleteByClusterID(ctx context.Context, clusterID uint) error {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-21T09:29:39Z

pkg/pr/dao/pipelinerun.go

@@ -95,7 +98,7 @@ func (d *dao) DeleteByClusterID(ctx context.Context, clusterID uint) error {
 	return result.Error
 }

-func (d *dao) DeleteByID(ctx context.Context, pipelinerunID uint) error {
+func (d *pipelinerunDAO) DeleteByID(ctx context.Context, pipelinerunID uint) error {


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2023-09-21T09:29:42Z

Code Climate has analyzed commit a5203e3 and detected 47 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	20
Duplication	27

The test coverage on the diff in this pull request is 70.6% (60% is the threshold).

This pull request will bring the total coverage in the repository to 65.9% (-0.1% change).

View more on Code Climate.

xuzhu-591 force-pushed the feat-approval branch 5 times, most recently from 3565113 to bfe8675 Compare September 18, 2023 11:28

codeclimate bot reviewed Sep 18, 2023

View reviewed changes

xuzhu-591 force-pushed the feat-approval branch from bfe8675 to 16e7722 Compare September 19, 2023 06:12

kilosonc and others added 6 commits September 19, 2023 14:36

feat: support release admit

537df54

Signed-off-by: closetool <[email protected]>

fix: support search pipelinerun by status

790ba78

Signed-off-by: kiloson <[email protected]>

fix: add open API

f8f0793

Signed-off-by: kiloson <[email protected]>

fix: add unit test

953d829

Signed-off-by: kiloson <[email protected]>

fix: unit test

4504627

Signed-off-by: kiloson <[email protected]>

feat: support for external approval

6d40918

Signed-off-by: xu.zhu <[email protected]>

xuzhu-591 force-pushed the feat-approval branch from 16e7722 to 2763d46 Compare September 19, 2023 06:39

codeclimate bot reviewed Sep 19, 2023

View reviewed changes

xuzhu-591 force-pushed the feat-approval branch 2 times, most recently from 3670732 to 98dcedf Compare September 19, 2023 08:10

fix: lint and ut

135cf6a

Signed-off-by: xu.zhu <[email protected]>

xuzhu-591 force-pushed the feat-approval branch from 98dcedf to 135cf6a Compare September 19, 2023 08:17

codeclimate bot reviewed Sep 19, 2023

View reviewed changes

kilosonc reviewed Sep 19, 2023

View reviewed changes

core/controller/pipelinerun/controller.go Outdated Show resolved Hide resolved

core/controller/pipelinerun/controller.go Outdated Show resolved Hide resolved

pkg/event/models/event.go Show resolved Hide resolved

xuzhu-591 added 2 commits September 20, 2023 16:53

fix: review

8a3b99e

Signed-off-by: xu.zhu <[email protected]>

fix: lint and ut

6cb1bb9

Signed-off-by: xu.zhu <[email protected]>

codeclimate bot reviewed Sep 20, 2023

View reviewed changes

fix: bugs

d505671

Signed-off-by: xu.zhu <[email protected]>

codeclimate bot reviewed Sep 20, 2023

View reviewed changes

fix: sql

a5203e3

Signed-off-by: xu.zhu <[email protected]>

codeclimate bot reviewed Sep 21, 2023

View reviewed changes

kilosonc approved these changes Sep 22, 2023

View reviewed changes

xuzhu-591 changed the title ~~Feat approval~~ Feat: support for pipelinerun checks Sep 22, 2023

xuzhu-591 merged commit d09b910 into horizoncd:main Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: support for pipelinerun checks #193

Feat: support for pipelinerun checks #193

xuzhu-591 commented Sep 12, 2023 •

edited

Loading

codeclimate bot Sep 18, 2023

codeclimate bot Sep 18, 2023

codeclimate bot Sep 18, 2023

codeclimate bot Sep 18, 2023

codeclimate bot Sep 18, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

codeclimate bot Sep 19, 2023

kilosonc left a comment

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 20, 2023

codeclimate bot Sep 21, 2023

codeclimate bot Sep 21, 2023

codeclimate bot Sep 21, 2023

codeclimate bot Sep 21, 2023

codeclimate bot Sep 21, 2023

codeclimate bot commented Sep 21, 2023

Feat: support for pipelinerun checks #193

Feat: support for pipelinerun checks #193

Conversation

xuzhu-591 commented Sep 12, 2023 • edited Loading

Description of your changes

How has this code been tested

Special notes for your reviewer

codeclimate bot Sep 18, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 18, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 18, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 18, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 18, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 19, 2023

Choose a reason for hiding this comment

kilosonc left a comment

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 20, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 21, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 21, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 21, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 21, 2023

Choose a reason for hiding this comment

codeclimate bot Sep 21, 2023

Choose a reason for hiding this comment

codeclimate bot commented Sep 21, 2023

xuzhu-591 commented Sep 12, 2023 •

edited

Loading