Update examples #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rewrite statement
Add uwsgi ini and nginx config
Switch to /usr/local/bin
swap package installation for pip install instructions
horazont
reviewed
Sep 26, 2018
| @@ -69,7 +69,8 @@ Clone and install:: | |||
| sudo mv xmpp-http-upload /opt/xmpp-http-upload | |||
| cd /opt/xmpp-http-upload | |||
| copy config.example.py config.py | |||
| sudo apt-get install python3-flask | |||
| sudo apt-get install python3-pip | |||
| sudo python3 -m pip install --upgrade flask-cors | |||
There was a problem hiding this comment.
I would prefer to not recommend installing flask from pip. flask-cors is still optional for that reason.
There was a problem hiding this comment.
So just keep the uwsgi examples and my updated nginx conf ? Is there a better way than to create a new branch, cherry pick, submit a new pr and abandon this one ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed up a bunch of things and added uwsgi examples like I promised last February 😄