Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment skipped tests because appmapp sees them as failed #131

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

hopsoft
Copy link
Owner

@hopsoft hopsoft commented Mar 1, 2024

No description provided.

Copy link

github-actions bot commented Mar 1, 2024

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns 🚨 4 new
New AppMaps 0️⃣ No new AppMaps
Removed AppMaps ✖️ 4 removed minitest tests

Code anti-patterns

🚨 New problems detected (4)

Data update performed in GET or HEAD request
Description

Data update performed in HTTP request GET /basic_command: INSERT INTO "users" ("session_id", "count", "created_at", "updated_at") VALUES (?, ?, ?, ?) RETURNING "id"

Field Value
Rule update-in-get-request
Impact domain Maintainability
View in AppMap
Stack trace
  • vendor/bundle/ruby/3.0.0/gems/activesupport-7.1.3.2/lib/active_support/callbacks.rb:597
Data update performed in GET or HEAD request
Description

Data update performed in HTTP request GET /basic_command: UPDATE "users" SET "count" = COALESCE("count", 0) - ? WHERE "users"."id" = ?

Field Value
Rule update-in-get-request
Impact domain Maintainability
View in AppMap
Stack trace
  • vendor/bundle/ruby/3.0.0/gems/activesupport-7.1.3.2/lib/active_support/callbacks.rb:597
Data update performed in GET or HEAD request
Description

Data update performed in HTTP request GET /tests: INSERT INTO "users" ("session_id", "count", "created_at", "updated_at") VALUES (?, ?, ?, ?) RETURNING "id"

Field Value
Rule update-in-get-request
Impact domain Maintainability
View in AppMap
Stack trace
  • vendor/bundle/ruby/3.0.0/gems/activesupport-7.1.3.2/lib/active_support/callbacks.rb:597
Data update performed in GET or HEAD request
Description

Data update performed in HTTP request GET /basic_command: UPDATE "users" SET "count" = COALESCE("count", 0) + ? WHERE "users"."id" = ?

Field Value
Rule update-in-get-request
Impact domain Maintainability
View in AppMap
Stack trace
  • vendor/bundle/ruby/3.0.0/gems/activesupport-7.1.3.2/lib/active_support/callbacks.rb:597

✖️ Removed AppMaps

[minitest] Reset frame increment once then reset and accept confirm

[minitest] Reset frame increment once then reset and dismiss confirm

[minitest] Reset no frame increment once then reset and accept confirm

[minitest] Reset no frame increment once then reset and dismiss confirm

@hopsoft hopsoft merged commit a81cfc4 into main Mar 1, 2024
10 checks passed
@hopsoft hopsoft deleted the hopsoft/test-skips-appmapp branch March 1, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant