Skip to content

Commit

Permalink
Fighting flaky system tests
Browse files Browse the repository at this point in the history
  • Loading branch information
hopsoft committed Feb 21, 2024
1 parent 9f5f9a3 commit 18ad3d0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ jobs:
run: 'npx playwright install chromium --with-deps'

- name: Run Tests
run: 'bundle exec rake test'
run: 'bundle exec rails test --fail-fast'
4 changes: 2 additions & 2 deletions test/application_system_test_case.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ def with_retries(max = 3)
return yield
rescue Playwright::Error, Minitest::Assertion => error
puts "RETRY #{count}: #{self.class.name}##{name}#{error.message}"
sleep 1
Capybara.reset_sessions!
sleep count * 3
# Capybara.reset_sessions!
page.reload waitUntil: "load"
raise if count >= max
end
Expand Down

0 comments on commit 18ad3d0

Please sign in to comment.