Solving issue #20 feat: add combobox component #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwarulislam
requested changes
Aug 12, 2024
There was a problem hiding this comment.
The component is not completed yet.
Instead of passing string and splitting it to filter is not a good idea.
- Pass an array and search on that array
- By default input field should be focused when we click
- Button navigation should work
- We should be able to pass slot as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #20 . Added a combobox component just like shadcn has, also added the search feature and took props input, the items to be entered separated by commas(,).I also added the feature to edit placeholder and search place holder. I have test the code and it works perfectly.