Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semicolon #196

Closed
wants to merge 4 commits into from
Closed

Add missing semicolon #196

wants to merge 4 commits into from

Conversation

UncleBill
Copy link

Update:
add v for var

@@ -15,7 +18,7 @@ snippet f
${3}
}${2:;}
# Immediate function
snippet (f
snippet )f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ok? It seems to me that (f is a better snippet than )f

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case of (f, parentheses auto-close plugin will give (f), that's annoying

@iurifq
Copy link
Collaborator

iurifq commented May 21, 2013

What a bunch of merge commits. Why don't you use rebase instead?

@UncleBill
Copy link
Author

@iurifq thanks for reply
I can't rebase, because I had pushed commits to remote.

@iurifq
Copy link
Collaborator

iurifq commented May 21, 2013

Yeah, you can with git push -f. It will enable force option.

@UncleBill
Copy link
Author

Thank you!
should I clean up these commits?
And what do you think of (f and )f by now?

@iurifq
Copy link
Collaborator

iurifq commented May 21, 2013

You should definitely clean them up.

You can leave )f. I got your reasons 😉

@UncleBill
Copy link
Author

wait ,I will squash the commits

@UncleBill
Copy link
Author

I think it's ready to merge 😃

@ghost ghost assigned honza May 21, 2013
@iurifq
Copy link
Collaborator

iurifq commented May 21, 2013

@honza can you take a look at this one?

@honza
Copy link
Owner

honza commented May 21, 2013

I'm not sure I like the )f either. I think we're trying to make a general tool and shouldn't be expected to work around everyone's issues.

@iurifq
Copy link
Collaborator

iurifq commented May 21, 2013

Agreed @honza. What do you guys thing of (f) ?

@honza
Copy link
Owner

honza commented May 21, 2013

While I totally appreciate the attempt to compromise, this just seems like it would defeat the purpose of having a snippet engine for most people. :)

Personally, I have my shift keys remapped to ( and ) so it wouldn't be such a problem...

@UncleBill
Copy link
Author

I believe there are many people using plugins provide parentheses auto-close.

@MarcWeber
Copy link
Collaborator

UncleBilll: snipmate has a "rewrite" option, so it should be easy to find all keys having a ( and replace that with ) automatically. See SnippetsWithFolding example in documentation - however you want to change the keys, not the values.
If you come up with an example we can add it to the documentation. I think you're right that quite a lot of people do use auto close plugins (I don't - but I'm not the average user). If you need help with that rewriting write back again.

@MarcWeber MarcWeber closed this Jun 18, 2013
@UncleBill
Copy link
Author

@MarcWeber I just checked out garbas/vim-snipmate#124. BTW, I am using Shougo/neosnippet.vim has alias feature, you can set alias for each snippet, multi alias is supported ( use , to separate )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants