New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: small improvements #94

Merged

yusukebe merged 4 commits into honojs:main from Yovach:perf/improve-calls

Nov 13, 2023

Contributor

Yovach commented Nov 12, 2023

I think these changes will bring small performance improvements because :

the split function call will stop when we've retrieved the 2 elements we're using. It also prevents people from putting unnecessary elements in the Range header, which can affect performance.
Reduce multiple assignments on start and end variables
Call the ReadableStream.getReader function only if the Writable is not destroyed.

Yovach added 4 commits

November 12, 2023 21:07


          perf(serve-static): range bytes with limit

12600fc


          ref: declare and set start in one line

1aa1dce


          ref: set default end value in one line

30becb6


          perf: don't create reader if writable is destroyed

89c1c92

Member

yusukebe commented Nov 13, 2023

Thanks. This is a good fix. LGTM!

yusukebe merged commit 3575d60 into honojs:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet