Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update valibot dependency to v1 #762

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

fabian-hiller
Copy link
Contributor

I've updated the Valibot dependency of the adapter to v1. We've changed the type signature, so this change is necessary. All other changes in our v1 beta version are only internal.


An union of schema library authors (Zod, Valibot, ArkType, ...) collaborating on a standard interface for schema libraries called Standard Schema. This simplifies implementation and prevents vendor lock-in. So far Valibot v1 supports this spec and Zod will follow soon. In the long run, the explicit implementation of a Valibot and Zod adapter may no longer be necessary.

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: bf1d9be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/valibot-validator Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Member

yusukebe commented Oct 5, 2024

Hi @fabian-hiller

Ah, Standard Schema seems to be great!

One thing I want you to do is to run the yarn changeset and push the changeset. This is a patch change. Thank you!

@fabian-hiller
Copy link
Contributor Author

Are you sure that this is a patch change? There will be TS errors if devs use Valibot v1 beta with the old adapter. I would release it as a 1.0.0-beta.0 or v0.4.0.

@yusukebe
Copy link
Member

yusukebe commented Oct 6, 2024

@fabian-hiller

Ah, I see! Shall we go with v0.4.0 (minor version up)?

@fabian-hiller
Copy link
Contributor Author

Sounds good to me. We can bumb to v1 once v1 is out.

@yusukebe
Copy link
Member

yusukebe commented Oct 7, 2024

@fabian-hiller

Thanks! Let's go!

@yusukebe yusukebe merged commit 05610f5 into honojs:main Oct 7, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants