-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tbValidator): Fix tbValidator not calling hook when there's a fail case #742
Conversation
🦋 Changeset detectedLatest commit: 267974a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add proper tests?
Hi @Micnubinub Thank you for the PR. There are something I want you todo. Can you check the comments? And can you run |
Ah, I see! Let's go with the array. |
@yusukebe let me know if you want me to change anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Great!! I'll merge it and release a new version. Thank you! |
No description provided.