Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tbValidator): Fix tbValidator not calling hook when there's a fail case #742

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

Micnubinub
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 267974a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/typebox-validator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add proper tests?

packages/typebox-validator/src/index.ts Show resolved Hide resolved
@yusukebe
Copy link
Member

Hi @Micnubinub

Thank you for the PR. There are something I want you todo. Can you check the comments?

And can you run yarn changeset at the top of this repo to create Changeset? This will be a minor change since introducing a new feature.

@Micnubinub
Copy link
Contributor Author

Micnubinub commented Sep 21, 2024

I'm good with it being the generator object, but I only did that to follow your convention here... Also used Array.from because of better support (older versions of js don't support spread operators on generators):
image

Also gonna be busy the next few days, so won't be able to get to the tests for some time, but happy to help when I get time

@yusukebe
Copy link
Member

@Micnubinub

I'm good with it being the generator object, but I only did that to follow your convention here...

Ah, I see! Let's go with the array.

@Micnubinub
Copy link
Contributor Author

@yusukebe let me know if you want me to change anything

@yusukebe yusukebe changed the title Fix tbValidator not calling hook when there's a fail case fix(tbValidator): Fix tbValidator not calling hook when there's a fail case Sep 24, 2024
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@Micnubinub

Great!! I'll merge it and release a new version. Thank you!

@yusukebe yusukebe merged commit 39cb252 into honojs:main Sep 24, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants